question UI Action already runs when loading form in Community Central forum

UI Action already runs when loading form

Christophe — Mon, 21 Jul 2025 06:31:49 GMT

Dear experts,

I created a UI Action to expire a contract manually. The Form Button works fine, but the problem is that the UI Action is triggered when the form loads.

UI Action

Name: Expire Contract
Table: ast_contract
Action name: expire_contract
Show update: True
Client: True
Form button: True
Onclick: setContractToExpired()
Condition: current.state == 'overdue'
Script:

function setContractToExpired() {
var comment = prompt("Please enter a comment before expiring the contract:");

if (comment === null || comment.trim() === "") {
alert("You must provide a comment.");
return;
}

setContractToExpired();

Script Include

Name: ExpireContractClientHelper
API Name: global.ExpireContractClientHelper
Client callable: True

Script:

var ExpireContractClientHelper = Class.create();

ExpireContractClientHelper.prototype = Object.extendsObject(AbstractAjaxProcessor, {

expireContract: function() {

var sysId = this.getParameter('sysparm_sys_id');

var comment = this.getParameter('sysparm_comment');

if (!sysId || !comment) {

return 'Missing parameters';

}

var contractGR = new GlideRecord('ast_contract');

if (contractGR.get(sysId)) {

contractGR.setValue('state', 'expired');

contractGR.setValue('description', comment);

contractGR.update();

return 'success';

} else {

return 'Contract not found';

}

});

I'm clearly doing something wrong, but I haven't got the foggiest what it is.

Thank you in advance for your help.

Best regards,

Chris.

Re: UI Action already runs when loading form

Pranesh072 — Mon, 21 Jul 2025 06:35:41 GMT

Remove the last setContractToExpired() function from your script

UI Action

Name: Expire Contract
Table: ast_contract
Action name: expire_contract
Show update: True
Client: True
Form button: True
Onclick: setContractToExpired()
Condition: current.state == 'overdue'
Script:

function setContractToExpired() {
var comment = prompt("Please enter a comment before expiring the contract:");

if (comment === null || comment.trim() === "") {
alert("You must provide a comment.");
return;
}

~~setContractToExpired();~~

Re: UI Action already runs when loading form

Chaitanya ILCR — Mon, 21 Jul 2025 06:43:00 GMT

Hi @Christophe ,

replace UI Action script

just removed last line which is calling the function

the button click calls the script there is no need to explicitly call it again

Please mark my answer as helpful/correct if it resolves your query.

Regards,
Chaitanya

Re: UI Action already runs when loading form

Tejas Adhalrao — Mon, 21 Jul 2025 06:53:35 GMT

Hi @Christophe ,

you did everything right . just you did one mistake.

Just remove this line from the bottom of your UI Action script:

setContractToExpired();

Your updated UI Action script should be:

And leave the OnClick field as

setContractToExpired()

PFA screenshots

Re: UI Action already runs when loading form

Christophe — Mon, 21 Jul 2025 06:59:46 GMT

That makes sense. Thank you very much for your help.

Re: UI Action already runs when loading form

Christophe — Tue, 22 Jul 2025 07:16:37 GMT

@Chaitanya ILCR Can I please ask you an additional question? I now put the comment in a field that already contains text, meaning that this text is being replaced. Is there a way to just add the comment to the existing text instead of replacing it? Thank you in advance for your help.

Re: UI Action already runs when loading form

Chaitanya ILCR — Tue, 22 Jul 2025 10:40:13 GMT

Hi @Christophe ,

you want to append the prompted value to the description ?

you can update the script include as this

if my understanding is wrong please share more details with some screenshots

Please mark my answer as helpful/correct if it resolves your query.

Regards,
Chaitanya