https://www.servicenow.com/community/community-central-forum/coding-suggestion-on-my-below-code-i-was-stuck-at-this-point/m-p/3034193#M780 <UL><LI>In the below code an I use sysid of the entity type market units directly in the code for checking the matchings. Is it comes under hard-coded? Will business team accept it or else do I need to get the sysid dynamically by querying the record. Pls suggest.</LI></UL><P>&nbsp;</P><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><OL><LI>var AllocationProfileValidationHelper = Class.create();<BR />AllocationProfileValidationHelper.prototype = {<BR />initialize: function() {},<BR /><BR />validateAllocationProfile: function(current) {<BR />var workplaceEntity = new GlideRecord('sn_wsd_core_workplace_entity');<BR /><BR />// Check if the workplace entity record exists<BR />if (!workplaceEntity.get(current.workplace_entity)) {<BR />gs.addErrorMessage("Invalid Workplace Entity.");<BR />return false;<BR />}<BR /><BR />var entityType = workplaceEntity.entity_type.toLowerCase();<BR />var allocationProfile = current.allocation_profile.toLowerCase();<BR />var isValid = true; // Assume validation is successful<BR /><BR />// Debugging information<BR />gs.info("Validation Check: Allocation Profile = " + allocationProfile + ", Entity Type = " + entityType);<BR /><BR />if (allocationProfile === 'owner') {<BR />// For 'Owner' profile, the workplace entity must be of type 'Market Unit'<BR />if (entityType !== 'fcffa877976e7554bf05b4221153af3b') {<BR />gs.addErrorMessage("Workplace Entity must be of type 'Market Unit' for 'Owner' profile.");<BR />gs.info("find if");<BR />isValid = false;<BR />}<BR />} else if (allocationProfile === 'tenant') {<BR />// For 'Tenant' profile, the workplace entity must NOT be of type 'Market Unit'<BR />if (entityType === 'fcffa877976e7554bf05b4221153af3b') {<BR />gs.addErrorMessage("Workplace Entity of type 'Market Unit' cannot be selected for 'Tenant' profile.");<BR />isValid = false;<BR />}<BR />}<BR /><BR />// Return the validation result<BR />return isValid;<BR />}<BR />};&nbsp;</LI></OL></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV> Mon, 02 Sep 2024 20:41:02 GMT Priyanka21 2024-09-02T20:41:02Z https://www.servicenow.com/community/community-central-forum/coding-suggestion-on-my-below-code-i-was-stuck-at-this-point/m-p/3034193#M780 <UL><LI>In the below code an I use sysid of the entity type market units directly in the code for checking the matchings. Is it comes under hard-coded? Will business team accept it or else do I need to get the sysid dynamically by querying the record. Pls suggest.</LI></UL><P>&nbsp;</P><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><DIV class=""><OL><LI>var AllocationProfileValidationHelper = Class.create();<BR />AllocationProfileValidationHelper.prototype = {<BR />initialize: function() {},<BR /><BR />validateAllocationProfile: function(current) {<BR />var workplaceEntity = new GlideRecord('sn_wsd_core_workplace_entity');<BR /><BR />// Check if the workplace entity record exists<BR />if (!workplaceEntity.get(current.workplace_entity)) {<BR />gs.addErrorMessage("Invalid Workplace Entity.");<BR />return false;<BR />}<BR /><BR />var entityType = workplaceEntity.entity_type.toLowerCase();<BR />var allocationProfile = current.allocation_profile.toLowerCase();<BR />var isValid = true; // Assume validation is successful<BR /><BR />// Debugging information<BR />gs.info("Validation Check: Allocation Profile = " + allocationProfile + ", Entity Type = " + entityType);<BR /><BR />if (allocationProfile === 'owner') {<BR />// For 'Owner' profile, the workplace entity must be of type 'Market Unit'<BR />if (entityType !== 'fcffa877976e7554bf05b4221153af3b') {<BR />gs.addErrorMessage("Workplace Entity must be of type 'Market Unit' for 'Owner' profile.");<BR />gs.info("find if");<BR />isValid = false;<BR />}<BR />} else if (allocationProfile === 'tenant') {<BR />// For 'Tenant' profile, the workplace entity must NOT be of type 'Market Unit'<BR />if (entityType === 'fcffa877976e7554bf05b4221153af3b') {<BR />gs.addErrorMessage("Workplace Entity of type 'Market Unit' cannot be selected for 'Tenant' profile.");<BR />isValid = false;<BR />}<BR />}<BR /><BR />// Return the validation result<BR />return isValid;<BR />}<BR />};&nbsp;</LI></OL></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV></DIV> Mon, 02 Sep 2024 20:41:02 GMT https://www.servicenow.com/community/community-central-forum/coding-suggestion-on-my-below-code-i-was-stuck-at-this-point/m-p/3034193#M780 Priyanka21 2024-09-02T20:41:02Z https://www.servicenow.com/community/community-central-forum/coding-suggestion-on-my-below-code-i-was-stuck-at-this-point/m-p/3034200#M781 <P>Yes, that is hard-coding. Program should not contain data.</P> <P>Worst case scenario, move the sys_id into a property.</P> <P>Best make user of a decision table that can be edited independently of code and that would describe the conditions for the selection to be valid.</P> <P>As for business team accepting this, unless you mean something else to what I understand that to be, they are not qualified to judge the solution.</P> Mon, 02 Sep 2024 21:21:19 GMT https://www.servicenow.com/community/community-central-forum/coding-suggestion-on-my-below-code-i-was-stuck-at-this-point/m-p/3034200#M781 -O- 2024-09-02T21:21:19Z