question Script not working in Developer forum

Script not working

sunil10 — Mon, 10 Mar 2025 13:13:08 GMT

Hi all

I am using below business rule on user table after update and active changes to false, everything is working fine state getting update worknotes getting updated but autosysfields not working, please suggest

(function executeRule(current, previous /*null when async*/ ) {

var grScReqItem = new GlideRecord('sc_req_item');

grScReqItem.addEncodedQuery("cat_item=32524947c32b9a1062c17ebdc00131a5^stateNOT IN3,4,7^requested_for=" + current.sys_id);

grScReqItem.query();

while (grScReqItem.next()) {

grScReqItem.setWorkflow(false);

grScReqItem.autoSysFields(false);

grScReqItem.work_notes = "RITM is closed incomplete as the requestor has been deactivated.";

grScReqItem.state = "4";

grScReqItem.update();

}

})(current, previous);

Re: Script not working

Brad Bowman — Mon, 10 Mar 2025 13:24:39 GMT

To clarify, are you saying that you don't want fields like updated by and updated on (or which fields specifically) to be updated when this rule triggers but they are getting updated, or they aren't updated and you want them to be updated?

Re: Script not working

sunil10 — Mon, 10 Mar 2025 13:27:16 GMT

@Brad Bowman

Script is working fine as required only issue i am facing is when worknotes and state getting update it is showing my name instead system

Re: Script not working

sunil10 — Mon, 10 Mar 2025 13:36:11 GMT

Re: Script not working

Ankur Bawiskar — Mon, 10 Mar 2025 13:41:31 GMT

@sunil10

ideally let the name be shown of that user who performs the action via the business rule.

what's your concern?

why you want to want with some other user?

If my response helped please mark it correct and close the thread so that it benefits future readers.

Re: Script not working

Ankit_Matta — Mon, 10 Mar 2025 13:46:51 GMT

you need to show updated by system?

Re: Script not working

Ankur Bawiskar — Mon, 10 Mar 2025 13:43:20 GMT

@sunil10

can you try this

(function executeRule(current, previous /*null when async*/) { var grScReqItem = new GlideRecord('sc_req_item'); grScReqItem.addEncodedQuery("cat_item=32524947c32b9a1062c17ebdc00131a5^stateNOT IN3,4,7^requested_for=" + current.sys_id); grScReqItem.query(); while (grScReqItem.next()) { grScReqItem.setWorkflow(false); grScReqItem.autoSysFields(false); // Update work notes without including the user's name grScReqItem.work_notes = "RITM is closed incomplete as the requestor has been deactivated."; grScReqItem.state = "4"; grScReqItem.update(); } })(current, previous);

If my response helped please mark it correct and close the thread so that it benefits future readers.

Re: Script not working

Brad Bowman — Mon, 10 Mar 2025 13:47:40 GMT

autoSysFields(false) disables updates to sys_updated_by, sys_updated_on, sys_mod_count, sys_created_by, and sys_created_on fields, which is not necessarily the same as something appearing in the activity stream. Can you confirm on the updated record that these fields were or or not updated with the change?

Re: Script not working

Dominik Simunek — Mon, 10 Mar 2025 13:50:31 GMT

My suggestion would be to not use "setWorkflow(false)" nor "autoSysFields(false)" when you are updating a real production data as part of user deactivation process. Those methods are helpful in case you are mass-updating data to just fix one field value for example. But in standard business process dangerous - e.g., turning off business rules might end up that a) SLAs running on RITM will not be completed, b) Metric Instances on RITM might not be completed and so on... many data inconsistency issues might pop up.

If the only problem is that your name is there - which is probably because you deactivated the user in your session, and onAfter BR run also under your session, then try to decouple the actions of 1) who is deactivating the user, 2) who is updating the RITMs. You can try "Async BR" if that is decoupling it from your session, or you could generate an event (like "sys_user.deactivated") in onAfter BR and have "Script Action" to be executed out of that event - then it would probably run under "system". I did not test any of these, but maybe it can help you.

Regards,

Dominik

Re: Script not working

sunil10 — Mon, 10 Mar 2025 13:51:01 GMT

@Ankur Bawiskar

tried with your code state is getting updated only , then nothing happens worknotes also no updated

Re: Script not working

sunil10 — Mon, 10 Mar 2025 13:51:51 GMT

@Ankit_Matta

Is this line " grScReqItem.autoSysFields(false);" working ? ---This is the only issue it is not working

Re: Script not working

Ankur Bawiskar — Mon, 10 Mar 2025 13:55:19 GMT

@sunil10

I will recommend not using those 2 lines and let it be audited and let subsequent logic run whenever RITM state is getting updated.

This will help from audit point of view as well.

If my response helped please mark it correct and close the thread so that it benefits future readers.

Re: Script not working

Brad Bowman — Mon, 10 Mar 2025 14:15:18 GMT

Rather than a Business Rule, you can run this script as a scheduled job - nightly, weekly, or whatever close RITMs that were opened by users who are now inactive... In the scheduled job setup there is an option to run the script as a certain user.