question Re: FX Currency returning incorrect value in Developer forum

FX Currency returning incorrect value

ceraulo — Wed, 06 Apr 2022 13:43:23 GMT

Hello!

There is a Cost currency field in the alm_hardware table.
I created another currency field called Cost (USD).
The objective is to display the USD equivalent to this custom field.

The USD equivalent is taken from the Reference amount field in the fx_currency_instance table.
I have created a BR that is triggered when the Cost field changes.

var gr = new GlideRecord('fx_currency_instance');
    gr.addQuery('id', current.sys_id);
    gr.addEncodedQuery('field=cost');
    gr.query();

    if (gr.next()) {
        var usd = gr.getValue('reference_amount');
    }

    gs.addInfoMessage(usd);
    current.u_cost_usd = usd;

The issue is the 'usd' value is not saved to the u_cost_usd field.
Any idea why the field is not updated?

Please help!

Thank you.

Re: FX Currency returning incorrect value

Anil Lande — Wed, 06 Apr 2022 14:19:07 GMT

Hi,

I hope you have cerate before update/insert BR. If not then please change it to before.

Thanks,
Anil Lande

Re: FX Currency returning incorrect value

Anil Lande — Wed, 06 Apr 2022 14:27:57 GMT

Hi,

Please create after BR Like below:

and use below script:

(function executeRule(current, previous /*null when async*/) {

	var gr = new GlideRecord('fx_currency_instance');
    gr.addQuery('id', current.sys_id);
    gr.addEncodedQuery('field=cost');
    gr.query();

    if (gr.next()) {
        var usd = gr.getValue('reference_amount');
    }
    gs.addInfoMessage(usd);
    current.u_cost_usd = usd;
	current.setWorkflow(false);
	current.update();

})(current, previous);

Thanks,

Anil Lande

Re: FX Currency returning incorrect value

ceraulo — Thu, 07 Apr 2022 08:03:27 GMT

@Anil Lande

I had to use an After BR because when the Cost field is updated, the value that is saved in the Cost (USD) field is the previous value. Is there a reason why this should be a Before BR?

The missing line in my script was the current.update().

Thank you.

Re: FX Currency returning incorrect value

ceraulo — Thu, 07 Apr 2022 08:11:25 GMT

@Anil Lande

This worked! Thank you.

A couple of questons though.

1. Why does it have to be a Before BR?
2. Why the need to setWorkflow to false?

Re: FX Currency returning incorrect value

Anil Lande — Thu, 07 Apr 2022 08:43:40 GMT

Hi,

1. Why does it have to be a Before BR?

Ans -> In your case before BR will not work because the value in fx_currency_instance table will be updated after your record is update. And using current.update() in before BR is not good practice, your record may go in recursion and may affect many other functionalities.

2. Why the need to setWorkflow to false?

Ans - If you want to update current record in BR then we should use setWorkflow(false) to avoid recursion. setworkflow(false) with update/insert operation will not execute any BR, notifications etc.

Thanks,
Anil Lande

Re: FX Currency returning incorrect value

Anil Lande — Thu, 07 Apr 2022 08:48:49 GMT

Glad to know provided solution worked for you.

Could you please close this question by marking an appropriate answer correct and other responses as helpful? It will be helpful for other community members to refer correct solution for similar issues in future.

You can post more questions if you any other queries and tag me if you need help from me, would be happy to reply on your question.

Thanks,

Anil Lande