question Reference variable loading so slow due to advanced reference qualifier and script include in Developer forum

Reference variable loading so slow due to advanced reference qualifier and script include

Hannah C — Mon, 18 Feb 2019 21:23:25 GMT

Hello!

I wrote a script include to user as a reference qualifier in a reference variable. The script works as intended, the problem is it is very slow so I'm thinking there must be something wrong. The else statement works great and loads the reference variable quick. However the if statement in bold (when the logged in user has the role) the reference variable will take almost 2 minutes to load the users. I know querying all active users is a lot, however before adding this reference qualifier, if the simple condition builder was just set to active is true it loaded quickly.

Please let me know if you have any tips for the script below:

var NHL_new_hire_user = Class.create();
NHL_new_hire_user.prototype = Object.extendsObject(AbstractAjaxProcessor, {

getNewHires: function() {

var user = [];

var current_user = gs.getUserID();

var roles = new GlideRecord('sys_user_has_role'); //query what roles the current user has and look for nhl role
roles.addQuery('user', current_user);
roles.addQuery('role', 'df97b1dcdbd0670092773220ad96196b'); //nhl_admin role
roles.query();

if (roles.next()){ //if the logged in user does have the nhl role
var all_users = new GlideRecord('sys_user'); //query all active users
all_users.addQuery('active', true);
all_users.query();

while(all_users.next()){
user.push(all_users.sys_id.toString()); //push an array of all active users
}
}

else{ //logged in user does not have nhl role
var user_manager = new GlideRecord('sys_user'); //querying active users whose manager is the logged in user
user_manager.addQuery('active',true);
user_manager.addQuery('manager', current_user);
user_manager.addQuery('u_contractor', false);
user_manager.query();

while(user_manager.next()){
user.push(user_manager.sys_id.toString()); //push an array of active users with logged user as manager
}
}

return 'sys_idIN' + user.join(',');
},

type: 'NHL_new_hire_user'
});

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Jon Barnes — Mon, 18 Feb 2019 21:47:36 GMT

Yes you can improve this. In your if section, just do this instead of querying all active users: return ‘active=true’;

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Jon Barnes — Mon, 18 Feb 2019 21:53:54 GMT

in Fact you don’t need to query the user table at all. I would rewrite your function like this: var ret = ‘active=true’; if (!gs.hasRole(‘nhl’)) { ret += ‘u_contractor=false^manager=javascript:gs.getUserID()’; } return ret;

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Hannah C — Mon, 18 Feb 2019 22:00:09 GMT

Thank you Jon! So those 5 lines will replace both the if statement and the else statement?

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Jon Barnes — Mon, 18 Feb 2019 22:07:25 GMT

Yes it would actually constitute the entire function. Just confirm the name of the role to check is “nhl”.

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Jon Barnes — Mon, 18 Feb 2019 22:10:17 GMT

Oh one update: The line inside the if statement should be (add the Caret at the front): ret += ‘^u_contractor=false^manager=javascript:gs.getUserID()’;

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Hannah C — Mon, 18 Feb 2019 22:17:33 GMT

Thanks Jon. It is not working...all active users are still showing up even if I don't have the nhl_requisition_admin role. I did verify this is the name of the role and tried doing the sys_id too.

This is what the full script include looks like now:

var NHL_new_hire_user = Class.create();
NHL_new_hire_user.prototype = Object.extendsObject(AbstractAjaxProcessor, {

getNewHires: function() {

var ret = ('active=true');
if (!gs.hasRole('nhl_requisition_admin')) {
ret += '^u_contractor=false^manager=javascript.gs.getUserID()';
}
return ret;
},

type: 'NHL_new_hire_user'
});

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Jon Barnes — Mon, 18 Feb 2019 22:25:28 GMT

If you are testing as an admin, admin users always return true for the gs.hasRole function. If you don’t want admins to see all active users, then you can put the query to the sys_user_has_role table back in. Does that get you where you need to be?

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Hannah C — Mon, 18 Feb 2019 22:28:25 GMT

Ohh okay, that makes sense. Let me try impersonating someone without admin and without the role and see if it works. Thanks!

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Hannah C — Mon, 18 Feb 2019 22:37:58 GMT

Ok so users with the role can see all active users. But users without the role see no users

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Jon Barnes — Mon, 18 Feb 2019 22:42:55 GMT

If you impersonate that same user, can they see any users if you navigate to the user list and add this query to your filters: Active Is true AND Contractor is false And Manager is (dynamic) Me

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Jon Barnes — Mon, 18 Feb 2019 22:45:03 GMT

Or you can get to it like this: /sys_user_list.do?sysparm_query=active=true^u_contractor=false^manager=javascript:gs.getUserID()

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Hannah C — Mon, 18 Feb 2019 22:45:31 GMT

Yes they have 11 users show up

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Jon Barnes — Mon, 18 Feb 2019 22:50:32 GMT

Oh I see a small typo in your script. Between javascript and gs.getUserID(), put a colon, not a period

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Hannah C — Mon, 18 Feb 2019 22:52:50 GMT

Yay it works!!! Thank you so so much!! I spent hours on this so you just made my day thank you.

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Hannah C — Mon, 18 Feb 2019 22:56:46 GMT

In case anyone else needs this, here is the final working scrip include:

var NHL_new_hire_user = Class.create();
NHL_new_hire_user.prototype = Object.extendsObject(AbstractAjaxProcessor, {

getNewHires: function() {

var ret = ('active=true');
if (!gs.hasRole('nhl_requisition_admin')) {
ret += '^u_contractor=false^manager=javascript:gs.getUserID()';
}
return ret;
},

type: 'NHL_new_hire_user'
});

Then on the reference variable that references the user table this is what I put in the reference qualifier field:

javascript: new NHL_new_hire_user().getNewHires()

So what this is if the logged in user has the nhl_requisition_admin role, the reference variable on the catalog item will load all active users for them to select from. If the logged in user does not have the role, it will only load users active users with the specified conditions.

Re: Reference variable loading so slow due to advanced reference qualifier and script include

Jon Barnes — Mon, 18 Feb 2019 22:59:40 GMT

Awesome! And thanks for all the “helpful” points!