question setMandatory is not working in my onchange script in ServiceNow AI Platform forum

setMandatory is not working in my onchange script

John Gomolon — Fri, 24 Jun 2016 10:43:36 GMT

This my onChange Client script that makes the comment field mandatory if correct state is selected.

My problem is that if i select state(1,2,4) the comment field will become mandatory and I select state(3), it wont become mandatory.

Could you help me on this, i don't know the root cause of this script because they are in the same IF.

Here is my code:

function onChange(control, oldValue, newValue, isLoading) {

if (isLoading || newValue == '') {

return;

}

var state = newValue;

if(state == '1' || state == '2' || state == '3' || state == '4'){

form.setMandatory('comments', true);

}

thanks,

Re: setMandatory is not working in my onchange script

ohhgr — Fri, 24 Jun 2016 10:48:18 GMT

Hi John,

I'm sure it is just a typo, but if not, please use g_form.setMandatory("comments", true);

Also, since this script is working for other states, check if there's any UI policy or other script that might be causing comments to not be mandatory.

Hope that helps.

Mandar

Re: setMandatory is not working in my onchange script

Harish KM — Fri, 24 Jun 2016 10:48:23 GMT

it is g_form.setMandatory('comments', true);

Re: setMandatory is not working in my onchange script

ramireddy — Fri, 24 Jun 2016 10:50:07 GMT

Apply IF condition for only 1,2,4. and also change "form" to "g_form".

function onChange(control, oldValue, newValue, isLoading) {

if (isLoading || newValue == '') {

return;

}

var state = newValue;

if(state == '1' || state == '2' || state == '4'){

g_form.setMandatory('comments', true);

}

else

g_form.setMandatory('comments', false);

}

Re: setMandatory is not working in my onchange script

John Gomolon — Fri, 24 Jun 2016 10:54:44 GMT

Sorry for the typo

There is no UI policy running. just the Script.

Re: setMandatory is not working in my onchange script

John Gomolon — Fri, 24 Jun 2016 10:55:32 GMT

Hi Ram,

Already did that but not working!

thanks

Re: setMandatory is not working in my onchange script

ohhgr — Fri, 24 Jun 2016 11:02:54 GMT

Hi John,

Let us simplify this even further. Put two alerts before and after the if condition to check if the control reaches till the comments part.

var stateValue = newValue;

alert("State is "+stateValue);

if(stateValue == '1' || stateValue == '2' || stateValue == '3' || stateValue == '4'){

alert("should set comments mandatory");

form.setMandatory('comments', true);

}

See, what responses you get for states 1 or 2 or 4 and for state 3.

Hope that helps.

Mandar

Re: setMandatory is not working in my onchange script

John Gomolon — Fri, 24 Jun 2016 11:07:25 GMT

Hi mandar,

I already did that and alerts for the all the state with correct value but still the comment is not mandatory.

Re: setMandatory is not working in my onchange script

ohhgr — Fri, 24 Jun 2016 11:28:28 GMT

Hi John,

That means there's no problem with this particular script. Please check other client scripts that might be working on comments field. Try disabling all other scripts (I know, its drastic) and run only this script. If even that doesn't work, I suggest raising an incident for HI.

Thanks,

Mandar

Re: setMandatory is not working in my onchange script

gowthamanbalu — Fri, 24 Jun 2016 12:15:33 GMT

Hi John,

I hope your form's current state value is not 3 when you test this. If so, Client script will not apply to that form, since you are running Onchange client script on the field state.

Here I would suggest to try by removing the below two lines of code in your client script and check once.

if (isLoading || newValue == '') {

return;

}

Regards,

Gowthaman Balu.

Re: setMandatory is not working in my onchange script

ramireddy — Fri, 24 Jun 2016 12:36:52 GMT

I tried an example. Its working. You need to start debugging. Please place few "alert" statements and check whether this event is firing or not, then whats the value is passing as newValue? I placed few alerts. Please let us know what are you getting as alerts.

function onChange(control, oldValue, newValue, isLoading) {

alert("In onchange event:newValue is" + newValue);

if (isLoading || newValue == '') {

return;

}

var state = newValue;

if(state == '1' || state == '2' || state == '4'){

alert("to set mandatory as true");

g_form.setMandatory('comments', true);

}

else

{

alert("to set mandatory as false");

g_form.setMandatory('comments', false);

}

Re: setMandatory is not working in my onchange script

John Gomolon — Mon, 27 Jun 2016 07:56:01 GMT

I already did that and alerts for the all the state with correct value but still the comment is not mandatory.

Re: setMandatory is not working in my onchange script

ramireddy — Mon, 27 Jun 2016 08:54:33 GMT

If the alerts are firing as intended and as per logic, then only issue will be name of "Catalog variable". Is the name is exactly "comments"?