BUSINESS RULE NOT CREATING NEW RITM AND NOT ATTACHING TO EXISTING REQ

[adaptivert]

Hello @everyone.  Good morning.  I need some help reviewing the business rule below and give me advise to correct the issue of the RITM not created and not added to an existing current REQ.  I appreciate the help.

------------------

(function executeRule(current, previous /*null when async*/) {

var catItemGr = new GlideRecord('sc_cat_item', 'Sailpoint IdN for Service Catalog');

catItemGr.get('name', 'Sailpoint Access Request');

try {

if (!current.variables.u_access_action || !current.variables.u_access_name) {

gs.info("Input validation failed <SP_SPNT_SN_INT_ManualConfigRITM>");

return;

}

gs.info("Business rule Line 11 <SP_SPNT_SN_INT_ManualConfigRITM> : " + current.variables.u_access_action.toString());

// Read the manual work table if access profile requires manual work

var accessTableGr = new GlideRecord('x_sap_intidn_manual_work_definition');

accessTableGr.addQuery('u_access_obj_name', current.variables.u_access_name.toString());

accessTableGr.query();

if (accessTableGr.next()) {

gs.info("Business rule Line 19 <SP_SPNT_SN_INT_ManualConfigRITM>: record matched");

// Create a new RITM record

var ritmGr = new GlideRecord('sc_cat_item');

ritmGr.name = catItemGr.name;

ritmGr.description = catItemGr.description;

ritmGr.insert();

gs.info("Line 27 <SP_SPNT_SN_INT_ManualConfigRITM> (ritm insert)");

// Add the RITM to the current active REQ

var reqRecord = new GlideRecord('sc_request');

reqRecord.addQuery('number', current.request.number);

reqRecord.query();

if (reqRecord.next())

{

    gs.info("Line 35 <SP_SPNT_SN_INT_ManualConfigRITM>-Parent REQ returned " + reqRecord.getRowCount() + " records");

    reqRecord.insert(ritmGr.sys_id);

    gs.info("Line 37 <SP_SPNT_SN_INT_ManualConfigRITM>-Parent REQ Insert");

    reqRecord.update();

    gs.info("Line 38 <SP_SPNT_SN_INT_ManualConfigRITM>-Parent REQ Update");

}

gs.info("Business rule Line 40 <SP_SPNT_SN_INT_ManualConfigRITM>");

gs.info("RITM created successfully. RITM sys_id <SP_SPNT_SN_INT_ManualConfigRITM: " + ritmGr.sys_id);

} else {

gs.info("No matching manual work definition found <SP_SPNT_SN_INT_ManualConfigRITM>");

}

} catch (err) {

gs.error("Error in business rule <SP_SPNT_SN_INT_ManualConfigRITM> : " + err);

}

})(current, previous);

---------------------

@tangcov 

[Bert_c1]

Your first line in the function is wrong

var catItemGr = new GlideRecord('sc_cat_item', 'Sailpoint IdN for Service Catalog');

should be

var catItemGr = new GlideRecord('sc_cat_item');

[adaptivert]

Thank you, @Bert_c1 .  I think I did the suggestion earlier and it was not executing good.  Let me try again with you advise.

[adaptivert]

Hi @Bert_c1 .  Change the definition as you suggested and the RITM is not created and REQ not updated.

[Bert_c1]

This section of code has problems:

		// Add the RITM to the current active REQ
		var reqRecord = new GlideRecord('sc_request');
		reqRecord.addQuery('number', current.request.number);
		reqRecord.query();
		if (reqRecord.next())
		{
			gs.info("Line 35 <SP_SPNT_SN_INT_ManualConfigRITM>-Parent REQ returned " + reqRecord.getRowCount() + " records");
			reqRecord.insert(ritmGr.sys_id);
			gs.info("Line 37 <SP_SPNT_SN_INT_ManualConfigRITM>-Parent REQ Insert");
			reqRecord.update();
			gs.info("Line 38 <SP_SPNT_SN_INT_ManualConfigRITM>-Parent REQ Update");
		}

where you have reqRcord.insert() (note: there are no arguments to insert()) and an "insert()" makes no sense on a record that exists. So remove that and leave the 'update()'. But then what field are you updating on the sc_request table. The record in sc_req_item uses a reference field to link the record to one in sc_request. just above the ritmGr.insert() add the code section

		// Add the RITM to the current active REQ
		var reqRecord = new GlideRecord('sc_request');
		reqRecord.addQuery('number', current.request.number);
		reqRecord.query();
		if (reqRecord.next())
		{
			gs.info("Line 35 <SP_SPNT_SN_INT_ManualConfigRITM>-Parent REQ returned " + reqRecord.getRowCount() + " records");
			ritmGr.request = reqRecord.sys_id;
		}

before the 'ritmGr.insert();'