State not updating in UI Action

[JennieD1]

Hi there! I have a business requirement for a form to have a button to change the state based on two conditions. 1. The form must have an attachment and 2. The form must have two mandatory questions answered. This application is in a scoped app. Thus far, I have created a UI Action and a script include. The logic I have works whenever I start a new record. My problem is, if I save a record and answer one of the conditions, but not the other, it is going ahead and updating the state. Can anyone help me with this? 

As you can see in the below image, my state has updated from open to work in progress, but only the attachment condition has been fulfilled. The 'Created & Assigned' and 'Test Fields' should still be mandatory and the state should still be open. 

UI Action

function changeState() {
     var ga = new GlideAjax("x_755950_disclos_0.getAttachmentsDisclosure");
     ga.addParam('sysparm_name', 'checkAttachment');
     ga.addParam('sysparm_sysID', g_form.getUniqueValue());
     ga.addParam('sysparm_tableName', g_form.getTableName());
     ga.getXML(validateForm);

     function validateForm(response) {
         var answer = response.responseXML.documentElement.getAttribute("answer");
         if (answer == "false") {
             g_form.addErrorMessage("You need to add an attachment");
             g_form.setMandatory('u_create_and_assigned', true);
             g_form.hideFieldMsg('u_create_and_assigned');
             g_form.showFieldMsg('u_create_and_assigned', "Please select an answer before changing the state.");
             g_form.setMandatory('test_field', true);
             g_form.hideFieldMsg('test_field');
             g_form.showFieldMsg('test_field', "Please select an answer before changing the state.");
         } else {
             g_form.setValue('state', 2);
             g_form.setMandatory('u_create_and_assigned', false);
             g_form.setMandatory('test_field', false);

         }

     }


     // gsftSubmit(null, g_form.getFormElement(), 'check_fields');
 }

Script Include:

var getAttachmentsDisclosure = Class.create();
getAttachmentsDisclosure.prototype = Object.extendsObject(global.AbstractAjaxProcessor, {

checkAttachment: function() {
    var sysID = this.getParameter('sysparm_sysID');
    var tableName = this.getParameter('sysparm_tableName');
    var attachment = new GlideSysAttachment();
    var agr = attachment.getAttachments(tableName, sysID);
    if (agr.next()) {
        return true;
    } else {
        return false;
    }
    },
    type: 'getAttachmentsDisclosure'

});

[JennieD1]

So when I add the quotes back to the false in my if statement, it works on the mandatory fields, but it is now not working for the attachment condition. 

[Danish Bhairag2]

Hi @JennieD1 ,

That is because no where in your Ui action code i could see that u are also validating for those 2 field being filled or not. You are just checking for attachment answer & based upon that u r executing some logic.

Thanks,

Danish

[JennieD1]

So would I do this in the UI action or Script Include? Also, would I need to make another script include? I am not super familiar with GlideAjax. 

[Danish Bhairag2]

Hi @JennieD1 ,

The issue seems to be in your "If" condition in your UI action code. If you observe you are returning a Boolean value from your script Include not a string so in your UI action code the condition should be,

if (answer == false) 

False should not be in qoutes.

Try removing that n check if it works or not.

Please mark my answer helpful & accepted if it helps you resolve your query.

Thanks,

Danish

[JennieD1]

This did not resolve the issue. Now the code isn't doing anything.