The Zurich release has arrived! Interested in new features and functionalities? Click here for more

Client Script help!

shane_davis
Tera Expert

I need some help creating a script for the process below.   Unfortunately, my limited scripting abilities isn't getting me the required results.   Any help is appreciated!

My full process is:

1. I open a Change Task which is assigned to me.

2. I choose my Failure Type and Failure Cause choices which puts an integer in the Failure Score (u_failure_score) field.

  •         All 3 fields are on the change_task table

3. The script should take the Failure Score and add it to the Failed Change Score field (u_failed_change_score) on the User table for the user assigned to the parent Change Request.

In addition, I need to delete the value of u_failed_change_score every 91 days because we only want to keep 90 days history in this field.

Below is code I've tried to create, but it's obviously not all I need...

function onChange(control, oldValue, newValue, isLoading, isTemplate) {

//Get value of u_failed_change_score on the sys_user table, add that to the u_failure_score on the change_task table, and then overwrite the current user's score with the new score.

var totalusrscore = g_form.getReference('sys_user');

// var f2 = g_form.getIntValue('totalusrscore.u_failed_change_score'); //Field on the sys_user table

var f1 = g_form.getIntValue('u_failure_score'); //Field on the change_task table

var total = f1 + totalusrscore.u_failed_change_score; //Add the 2 fields together to get the sum

g_form.setValue('f2', total); //set the score on the sys_user table to the new score

}

1 ACCEPTED SOLUTION

I would create a business rule to run "After" the record has updated. This will only add the current updated score to the existing score on their user record. See the scheduled job below for how to remove anything previous to 90 days.



Here is the script:


(if you're on ServiceNow Eureka, check the Advanced checkbox)


Insert = True


Update = True


When to run = After


Condition: current.u_failure_score.changes()


Script:


var u_usr = new GlideRecord('sys_user');


u_usr.addQuery('sys_id',current.change_request.assigned_to);


u_usr.query();


if (u_usr.next()){


u_usr.u_failed_change_score += current.u_failure_score;


u_usr.update();


}




Also since you want to remove anything past 90 days old, I believe you should have a daily scheduled job to recalculate the score that runs this script:


var u_usr = new GlideRecord('sys_user');


var u_cTask = new GlideRecord('change_task');


var u_sum = new GlideAggregate('change_task');



//Find all change tasks created in the last 90 days


u_cTask.addEncodedQuery('sys_created_onONLast 90 days@javascript:gs.daysAgoStart(90)@javascript:gs.daysAgoEnd(0)');


u_cTask.query();


while (u_cTask.next()){


var u_at = u_cTask.change_request.assigned_to;




//aggregate the sum of the failure scores grouped by assigned to


u_sum.addAggregate('SUM', 'u_cTask.u_failure_score');


u_sum.groupBy(u_at);


u_sum.query();


while (u_sum.next()){


var total = u_sum.getAggregate('SUM','u_cTask.u_failure_code');




//Here is where you should set that value back to the user record by updating the sys_user table.


//I'm not 100% sure of the code here, but add gs.log statements in the script above to see what


//output you are getting.




//You need something like for each assigned to user, set the u_failed_change_score to be the


//sum aggregate we got from the above query.








View solution in original post

29 REPLIES 29

Ah sorry! Look for script log in the left nav. tell me if you see your line print out there.


I changed my business rule to the below and the log is giving the previous and current values in the log!   I also changed the "if" statement under the else to reference the task scores rather than the user scores, but it still doesn't subtract then add.   Thank you so much for your help.



var user = new GlideRecord('sys_user');


user.addQuery('sys_id',current.change_request.assigned_to);


user.query();


if (user.next()){


if (user.u_failed_change_score == 0 || user.u_failed_change_score == ''){


  user.u_failed_change_score += current.u_failure_score;


  user.update();


}


else {


gs.log("The failed change scrore is " + previous.u_failure_score + "&" + current.u_failure_score);


  if (previous.previous.u_failure_score != current.u_failure_score){


    user.u_failed_change_score -= previous.u_failure_score;


    user.u_failed_change_score += current.u_failure_score;


  }


}


}




log.PNG


I would recommend changing your "var user = new GlideRecord('sys_user');" back to u_usr as a best practice. Sometimes the system can get confused with variables that are declared elsewhere. Which means updating all the instances of "user" to "u_usr".



I think you're missing the .update() in the else statement. I would move user.update() out of both the if /else statement braces and put it right before you close the if condition. Let me know how that goes.


Also when you do gs.log statements, as a best practice, make sure you either comment them out or remove them before you push to prod. It makes your logs a lot cleaner


HOORAY!   It works!   You are amazing.   Now I just have the part of making my user's score keep a rolling 90 days and then change the color of the Change Request's assigned to based on that score!   Without your help, I don't know what I would have done.   Thank you very much!!   I will try to post the entire solution when I'm done.



var u_usr = new GlideRecord('sys_user');


u_usr.addQuery('sys_id',current.change_request.assigned_to);


u_usr.query();


if (u_usr.next()){


if (u_usr.u_failed_change_score == 0 || u_usr.u_failed_change_score == ''){


  u_usr.u_failed_change_score += current.u_failure_score;


}


else {


  // gs.log("The failed change scrore is " + previous.u_failure_score + " & " + current.u_failure_score);


  if (previous.previous.u_failure_score != current.u_failure_score){


    u_usr.u_failed_change_score -= previous.u_failure_score;


    u_usr.u_failed_change_score += current.u_failure_score;


  }


 


}


u_usr.update();


}