Advanced workflow user approval

rbertram · ‎12-06-2012

I am trying to create a user approval task using an advanced script and it is generating system errors. The user I am trying to set as the approver is the group manager. The group is set based on a lookup select box variable on a SC requested item form.

This is my script:



var group = new GlideRecord('sys_user_group');
group.addQuery('sys_id',current.variables.workgroup);
group.query();
while (group.next()) {
   var groupMgr = group.manager;
   gs.log('Group manager sys_id: ' + groupMgr.sys_id.toString());
   answer.push(groupMgr.sys_id.toString());
}

I added a log statement to verify that the sys_id is valid on the sys_user table.

This is the warning that is generated in the system log:

org.mozilla.javascript.EcmaError: Cannot convert null to an object.
Caused by error in Script Include: 'WFActivityHandler' at line 110

107:
108: // start with answer as null so we can tell if the script changes it
109: workflow.setVariable("answer", null);
==> 110: var retVal = workflow.eval(script);
111: var answer = workflow.getVariable("answer");
112: if (answer === null)
113: answer = retVal; // legacy support for returning a value from the script

rbertram · ‎12-07-2012

It is now working. Thanks for your help. I took it a step further and created a Run Script action to save the group's manger to the workflow scratchpad so I could reference it in an If activity so if the group's manager is the person submitting the request it is automatically approved.

Run Script:



getGroupManager();

function getGroupManager() {
   var group = new GlideRecord('sys_user_group');
   group.addQuery('sys_id',current.variables.workgroup);
   group.query();
   while (group.next()) {
      var group_manager = group.manager;
  workflow.scratchpad.groupMgr = group_manager.sys_id;
   }
}

If activity:



answer = ifScript();
function ifScript () {
   if (workflow.scratchpad.groupMgr == current.opened_by.sys_id) {
  return 'yes';
   }
   return 'no';
}

Approval - User:



answer = [];
answer.push(workflow.scratchpad.groupMgr.toString());

View solution in original post

rbertram · ‎07-26-2018

Something I just noticed, remove the 'var' in front of answer = []

crazylogic · ‎07-27-2018

Thank you very much for your feedback!! I was able to fix my issue. I hope you don't mind me posting my final code in hopes that it may help others.

This does a lookup in a custom table where a ref to user records is stored. I then loop through the records to gather the user sys_ids and then store this in a string instead of an array. I then push the string into the 'answer' variable. I am not 100% certain what fixed this but I suspect your suggestions and avoiding multiple answer.push command was helpful.

Thanks again!

var ApproverSYSUSERsysid = '';

var cerApproverMatrixRecords = current.variables.var_cer_5KApprovers;
workflow.info('......cerApproverMatrixRecords = ............' + cerApproverMatrixRecords);

var gr = new GlideRecord('u_cer_approval_matrix');
var qq = gr.addQuery('u_approval_limit','5000'); //Approval Limit = 5000
gr.addQuery('sys_id','IN',cerApproverMatrixRecords);

gr.query();

workflow.info("..........u_cer_approval_matrix query done.......grabbing approvers next but I NEED to count this because I DOUBT I am getting any records here...");