Approver process on demands for approvers stakeholders

Rajeshshardul · 3 weeks ago

Hi Everyone,

Configured BR's and Properties as per community suggestion.

But Facing the below issues,

1. Approvers are getting added twice.

2. Once Approvers approving the state of demand not changing into Approved.

3. When Refreshing window Same Approver ID adding again.

Business Rules:

BR Name - Demand Approval Request

When to Run - After with update and condition added as state = Qualified

Script:

(function executeRule(current, previous /*null when async*/ ) {

var grStakeHolder = new GlideRecord('dmn_m2m_demand_stakeholder');

grStakeHolder.addQuery('demand', current.sys_id);

grStakeHolder.addQuery('approver', 'yes');

grStakeHolder.query();

while (grStakeHolder.next()) {

var grApproval = new GlideRecord('sysapproval_approver');

grApproval.initialize();

grApproval.approver = grStakeHolder.stakeholder.user;

grApproval.state = 'requested';

grApproval.source_table = current.sys_class_name; // Not hard coded to support TeamSpaces

grApproval.document_id = current.sys_id;

grApproval.sysapproval = current.sys_id;

grApproval.insert();

}

})(current, previous);

BR Name: Demand Approved

When to Run: Before Update and condition is Approval changes to Approved.

Action did set as : State is Approved.

Demand

System Properties -> Approval Engines
Did Update Demand Approval Engine to: Approval Rule

Issue Snapshots:

Initially it is adding id two times and once approved and then after screen refreshing adding id's again and again.

State value is not changing

Please help me on it.

Rajeshshardul · 3 weeks ago

Fixed issue with below script.

1. Business Rule Name: Demand Approved

When to Run: After with update and condition is state changes to Approved

Script:

(function executeRule(current, previous) {

// Run only when approval is approved

if (current.state != 'approved')

return;

// Get Demand record

var demand = new GlideRecord('dmn_demand');

if (!demand.get(current.sysapproval))

return;

// Check if any approvals are still pending

var pending = new GlideRecord('sysapproval_approver');

pending.addQuery('sysapproval', demand.sys_id);

pending.addQuery('state', '!=', 'approved');

pending.query();

// If all approvals are approved

if (!pending.hasNext()) {

demand.setValue('state', '8');

demand.setValue('approved_start_date',demand.getValue('start_date'));

demand.setValue('approved_end_date',demand.getValue('requested_by'));

demand.update();

}

})(current, previous);

2.

Business Rule Name: Demand Approval Request

When to Run: After with update and condition is state changes to Qualified

Script:

(function executeRule(current, previous) {

var grStakeHolder = new GlideRecord('dmn_m2m_demand_stakeholder');

grStakeHolder.addQuery('demand', current.sys_id);

grStakeHolder.addQuery('approver', 'yes');

grStakeHolder.query();

while (grStakeHolder.next()) {

// 🔍 Check if approval already exists

var grApprovalCheck = new GlideRecord('sysapproval_approver');

grApprovalCheck.addQuery('sysapproval', current.sys_id);

grApprovalCheck.addQuery('approver', grStakeHolder.stakeholder.user);

grApprovalCheck.query();

if (!grApprovalCheck.hasNext()) {

var grApproval = new GlideRecord('sysapproval_approver');

grApproval.initialize();

grApproval.approver = grStakeHolder.stakeholder.user;

grApproval.state = 'requested';

grApproval.source_table = current.sys_class_name;

grApproval.sysapproval = current.sys_id;

grApproval.insert();

}

})(current, previous);

Demand

System Properties -> Approval Engines
Did Update Demand Approval Engine to: Approval Rule

View solution in original post

Itallo Brandão · 3 weeks ago

Hi @Rajeshshardul ,

Unfortunately, the screenshots are too blurry to read.

Could you please re-upload them with higher resolution?

Also, if you can paste the Script code directly here as text, it would be much easier for us to help you debug the logic.

Best regards,
Brandão.

Rajeshshardul · 3 weeks ago

Hi @Itallo Brandão ,

Added code which i used and Snapshots readded.

Please help me out to fix the issue.

BR,

Rajesh.

Itallo Brandão · 3 weeks ago

Hi @Rajeshshardul ,

Quick tip regarding the screenshots:

The Community editor heavily compresses images when you paste them directly into the text body, making them blurry.

To ensure we can read them clearly next time, please upload the image files using the Attachments section at the bottom of the post editor instead of pasting them.

Best regards,
Brandão.

Rajeshshardul · 3 weeks ago

Thanks for you inputs and Script did fixed from my side and shared updated code in below.