create a fix script to add evt_mgmt_operator role to itil , getting errors

[ServNowDev]

addRoletoRole();

function addRoletoRole(){
    // Find the ITIL role
    var itilRole = new GlideRecord('sys_user_role');
    itilRole.addQuery('name', 'ITIL');
    itilRole.query();

    if (itilRole.next()) {
        // Check if the evt_mgmt_operator role already exists in ITIL role
        var itilRoles = itilRole.getValue('roles');
        if (itilRoles.indexOf('evt_mgmt_operator') === -1) {
            // Add evt_mgmt_operator role to the ITIL role
            var newRoles = itilRoles + ',evt_mgmt_operator';
            itilRole.setValue('roles', newRoles);
            itilRole.update();
            gs.info('evt_mgmt_operator role added to ITIL role successfully.');
        } else {
            gs.info('evt_mgmt_operator role already exists in ITIL role.');
        }
    } else {
        gs.error('ITIL role not found.');
    }
}

getting error below:

Evaluator: com.glide.script.RhinoEcmaError: Cannot convert null to an object.
   script : Line(12) column(0)
      9:     if (itilRole.next()) {
     10:         // Check if the evt_mgmt_operator role already exists in ITIL role
     11:         var itilRoles = itilRole.getValue('roles');
==>  12:         if (itilRoles.indexOf('evt_mgmt_operator') === -1) {
     13:             // Add evt_mgmt_operator role to the ITIL role
     14:             var newRoles = itilRoles + ',evt_mgmt_operator';
     15:             itilRole.setValue('roles', newRoles);

[0:00:00.022] Total Time

[ServNowDev]

I need all user with the itil role to have the role evt_mgmt_operator role as well

[Mark Roethof]

Shouldn't you be checking the sys_user_has_role table then? Or sys_user and it's roles field?

Now you are querying the sys_user_role table, which will simply not work.

Kind regards,
Mark

[Manmohan K]

Hi @ServNowDev 

Why are you adding role via script

You should be adding it directly from System UI

[ServNowDev]

adding the role(evt_mgmt_operator) to the itil role will not take for some reason 

[Manmohan K]

Can you share the error 

Also rather than adding evt_mgmt_operator in the itil role, consider creating a custom role and add itil and evt_mgmt_operator role to it

This way you do not give additional access to people having itil role