How to do this , reducing Client scripts, Is it good idea ?

[Sironi]

Hi All,

Kindly help me on my concern, 

if we have multiple OnChange client scripts on single field on same table , there Reducing all client scripts into single OnChange is Good Idea ?

if reducing  is Good Idea , then why ServiceNow OOB has multiple scripts on single field on same table ?  , they should have designed in Single -OnChange script . why they didn't design in single OnChange script ?

Please share your opinions and suggestions on this.

[Ankur Bawiskar · Accepted solution]

@Sironi 

yes it's recommended but sometimes each onChange is written to handle different use-case.

But if the script becomes too complex with multiple IF else then better to separate those out.

Developers might have created new onChange on state field without noticing there was already onChange.

If my response helped please mark it correct and close the thread so that it benefits future readers.

[Nikhil Bajaj9 · Accepted solution]

Hi @Sironi ,

Although there are multiple client scripts on same field but there requirements and codes are different. You can't put all conditions/requirement in one client script. It will be very messy to understand and very difficult to maintain code so code is always broken down into pieces (one requirement, one code) for better readability, maintenance.

I dont think clubbing multiple codes/requirements in one scrip tis possible and advisable.

If my answer helped you in anyways, please mark it solution accepted.

Regards,

Nikhil Bajaj

[Mark Manders · Accepted solution]

If you do everything with one client script, it will be very complex to add another requirement to it, because every single use case that is handled through that client script, will have to be tested again. 

It will be difficult to troubleshoot and when you are making Ajax calls it becomes impossible to follow. 

Breaking it down helps with making it understandable (the title of the client script already tells you what it does) and it is easily changed.

That being said: if it is handling the same use case, it should be in the same script. My experience is that often things are added instead of updated. Many 'developers' just add something to comply to certain requirements instead of checking what's already there. 

So you could probably combine some of those scripts, but make sure it stays easy to troubleshoot/read and also maintainable.

[Mark Manders · Accepted solution]

If you do everything with one client script, it will be very complex to add another requirement to it, because every single use case that is handled through that client script, will have to be tested again. 

It will be difficult to troubleshoot and when you are making Ajax calls it becomes impossible to follow. 

Breaking it down helps with making it understandable (the title of the client script already tells you what it does) and it is easily changed.

That being said: if it is handling the same use case, it should be in the same script. My experience is that often things are added instead of updated. Many 'developers' just add something to comply to certain requirements instead of checking what's already there. 

So you could probably combine some of those scripts, but make sure it stays easy to troubleshoot/read and also maintainable.

[Sironi]

Thanks for your reply and sharing your opinion.

 best practice is design solution in separate script based on complexity of requirements , so it will be  easy for readable, maintainable , Testing and troubleshooting.

if we get 20 complex requirments does not match each other requirement  then so obviously we have to design 20 scripts, does it creates any performance issue ?

 

[JackieZhang]

I have a different viewpoint. Whether to merge onchange on the same field into one depends on your debugging needs in the later stage. If there are too many and conflicting suggestions that are not conducive to debugging, merge them into one. If it is an independent function, it is recommended to separate it

[Sironi]

Thanks for your reply and sharing your opinion

[Sironi]

Thanks to Everyone . thanks for sharing pros and cons  and having discussion .
Everyone suggested that best practice is design solution in separate script based on complexity of requirements , so it will be  easy for readable, maintainable , Testing and troubleshooting.

if we get 30 requirments on same field on same table does not match each other requirement  then so obviously we have to design 30 scripts, does it creates any performance issue ?