While loop stuck infinitely repeating

Christopher Ros · ‎06-03-2020

Hello everyone! So I have an API that creates Requests. I've recently been coding to account for duplicate returns. The expected behavior is a while loop that is supposed to cycle through every active employee ID it finds, creating a REQ for each, then finish. For whatever reason it's repeating the one return infinitely.

Here's the code:

var gr = new GlideRecord('sys_user');
gr.addQuery('employee_number',requestObjFields.employee_id);
gr.addQuery('active',true);
gr.query();
while(gr.next()){
var EmployeeTermCatalogItemID = "5cd3e62bdbdb7300ceec3caf9d96196d";
var catalogItemVariables = buildCatalogItemVariables(RequestObject);
if(error.occured){
return error.content;
}
var cart = new Cart(null,catalogItemVariables.term_supe);
var item = cart.addItem(EmployeeTermCatalogItemID,1);

for(var key in catalogItemVariables){
var value = catalogItemVariables[key];
cart.setVariable(item,key,value);
}
var reqGR = cart.placeOrder();
response.setBody({
'Number':reqGR.getValue('number'),
'URL':"https://"+gs.getProperty('instance_name')+".service-now.com/sp?id=sc_request&sys_id="+reqGR.getUniqueValue()+"&table="+reqGR.getTableName()
});
}

Any help is GREATLY appreciated! Thank you!

Allen Andreas · ‎06-04-2020

It's absolutely no problem. Keep asking questions!

So per your API code you posted above...it's setting it to null?

"employee_id":"",

So...while you're using the key and value, per that script, it's setting it to "null" aka nothing.

And then in your query, as Mwatkins mentioned, it's basically treating it as if you're asking for:

gr.addQuery('employee_number', '');

Null.

Try that as a test search and I would imagine you'll see that you get 669 records back or whatever that count was as if when you used

gr.addQuery('employee_number',requestObjFields.employee_id);

Let us know?

So you need to check what you're getting for requestObjFields.employee_id literally and you'll see that it must be a payload issue. So your object is being built with no data, basically...

Please mark reply as Helpful/Correct, if applicable. Thanks!

Please consider marking my reply as Helpful and/or Accept Solution, if applicable. Thanks!

View solution in original post

Christopher Ros · ‎06-04-2020

Because of this tidbit I renamed the var to grUD (naming convention makes sense within the context). Thanks for the tidbit, and something I'll have to keep in mind. My habit right now is definitely to just throw gr in there, not a good thing obviously. Thanks!

DirkRedeker · ‎06-04-2020

Hi

Did that solve the problem right now?

Just tell me.

BR

Dirk