Business Rule Scripting Help - Query other table and change current field

[JWayner]

I'm trying to set up a business rule to check if the data in a field called control_number in another table matches the current record number. If yes, then in the current record, I want to change the internal_validation_performed field to true. 

I've tried it as a before and after rule. I've selected update and insert. I can't seem to get it to work. I've added an info message throughout and no matter what, the info message is returned successfully (regardless if the query requirements are met), meaning the query is not working properly. Can anyone help?

(function executeRule(current, previous /*null when async*/) {

var currentNumber = current.getValue('number'); 
var controlTests = new GlideRecord('x_hotm_orm_risk_registry');
controlTests.addQuery('control_number', currentNumber);
controlTests.query();

if (controlTests.next()) {
current.setValue('internal_validation_performed', true);
}

})(current, previous);

[JWayner]

That was it! The control_number reference field references sys IDs. As soon as I changed number to sys_ID, it started working properly. Thank you so much!

[Riya Verma]

Hi @JWayner ,

Hope you are doing great . 

Use After Business rule , and try to use current.setWorkflow (false)  to avoid retriggering the BR.

(function executeRule(current, previous /*null when async*/) {
    var currentNumber = current.getValue('number');
    var controlTests = new GlideRecord('x_hotm_orm_risk_registry');
    controlTests.addQuery('control_number', currentNumber);
    controlTests.query();
    
    if (controlTests.next()) {
        current.setValue('internal_validation_performed', true);
        current.setWorkflow(false); // To prevent retriggering the business rule
        current.update(); // Save the changes to the current record
    }
})(current, previous);

 Please try using this updated script,

[JWayner]

Thanks for your quick response, Riya. Unfortunately, it's still not working. The only way I seem to be able to get anything to happen is by adding the source table as a variable and referencing it in the currentNumber variable. If I do this, the internal_validation_performed field becomes true in every record. 

(function executeRule(current, previous /*null when async*/) {
    var controlTable = new GlideRecord ('x_hotm_orm_control_registry');
    var currentNumber = controlTable.getValue('number');
    var controlTests = new GlideRecord('x_hotm_orm_risk_registry');
    controlTests.addQuery('control_number', currentNumber);
    controlTests.query();
    
    if (controlTests.next()) {
        current.setValue('internal_validation_performed', true);
        current.setWorkflow(false); // To prevent retriggering the business rule
        current.update(); // Save the changes to the current record
    }
})(current, previous);