Creating Group Approvals in a Workflow Via Script Not Behaving Properly

[jmiskey]

Typically, we use the Group Approval action in the Workflow to create group approvals.  However, we have Catalog Items where users can select more than one "role" to request, and each "role" has its own Approval Group, which is maintained by a Role Data Dictionary table.  So we have a Run Script action, which loops through all the Roles they have selected, and creates a separate Group Approval for each one.  The code looks something like this:

//capture roles selected from variable
var roleList = current.variables.role.toString();

//loop through all roles
var roleArray = roleList.split(',');
for (var i = 0; i < roleArray.length; i++) {
	var rol = roleArray[i];
	var gr = new GlideRecord('u_tango_roles');
	gr.addQuery('sys_id', rol);
	gr.query();
	
	//create group approvals
	with (gr.next()){
		if (gr.u_approval_needed == true){
			var appGrp = gr.u_role_approver;
			var role_name = gr.u_role_name;

			//create group approval
			var grApproval = new GlideRecord('sysapproval_group');
			grApproval.initialize();
			grApproval.parent = current.sys_id; 
			grApproval.assignment_group = appGrp;   
			grApproval.approval = 'requested';
			grApproval.wait_for='any';  //wait for anyone to approve
			grApproval.insert();
			
			//add approval types to approver approval records
			var apprv = new GlideRecord("sysapproval_approver");
			apprv.addQuery("sysapproval", "=", current.sys_id);
			apprv.addQuery("state", "=", 'requested');
			apprv.addQuery("u_approval_type", "=", "");
			apprv.query();
			while (apprv.next()) {
				apprv.u_approval_type = 'Tango: ' + role_name + ' Approval';
				apprv.update();
			}
		}
	}
}

So, this script does correctly create the Group Approval records, and the accompanying Approver Approval records, for each member in the groups. 

It does what it is supposed to, except for one big thing.  Even though we have the "Wait For" field set to "any" (so that once one person approves or rejects an approval, all other approval records created for that particular approval are deemed unnecessary), it is not working properly.  If one person approves a particular approval, all the other persons in that group still have their individual approval records showing as "Requested" instead of "No Longer Required".

I compared these approvals created by scripts against one that are created by the Group Approval action (and behave like they should), and could not find any differences.  In both cases, the following values on the Group Approval record are the same:

- Wait for: Anyone to approve

- Upon approval: Proceed to next task

- Upon reject: Cancel all future tasks

What am I doing wrong?  Am I missing some sort of setting?

How do I get the Group Approval (accompanying user approval records created) created by a Run Script action to behave in the same manner as one created with the Group Apprval action?

Thanks

[elphilli]

Right! I used the logging statements you recommended and see where the locations are getting captured. So that part is correct. The logging statement on the creating group approval is returning one sys_id instead of multiple.

[jmiskey]

If you can show us where you added your log statements to your code, and what each one returned, we may be able to help you debug it.

[elphilli]

var answer = [];

//capture Badge Locations selected from variable
var badgeList = current.variables.select_plant_access_select_all_that_apply.getDisplayValue().toString();

gs.log(badgeList, "Badge Locations");
***returns the display values for the locations selected in list collector.

//loop through all Locations
var badgeArray = badgeList.split(',');
for (var i = 0; i < badgeArray.length; i++) {
    var badge = badgeArray[I];

gs.log(badgeArray, "Locations Array");
***Collects all the locations and split each value with comma

gs.log(i, "Badge I");
***start with 0 being the first value selected

    var gr = new GlideRecord('u_badge_doors_updated');
    gr.addQuery('u_location', badge);
    gr.query();

    //create approvals
    while (gr.next()) {
        var approval = gr.u_approval_groups(badge);
        answer.push(approval.toString());
		
gs.log(approval, 'badge approval');
***returns one sys_id.
    }
}

[jmiskey]

I see some potentials errors, such as here:

for (var i = 0; i < badgeArray.length; i++) {
    var badge = badgeArray[I];

I believe it is case-sensitive, so the second line would need to be:

    var badge = badgeArray[i];

And I think that instead of this:

gs.log(badgeArray, "Locations Array");

your log statement should probably be:

gs.log(badgeArray[i], "Locations Array");

And I think you have an error here:

       var approval = gr.u_approval_groups(badge);

I think it should just be:

       var approval = gr.u_approval_groups;

[elphilli]

With the changes made, the log statements are returning values as expected. However, the "var approval = gr.u_approval_groups" still creates one Group Approval.