Hi John,
For easier maintainability, keep the condition as short as possible. If the computation is complex, it is difficult to read and understand. Rather than increasing the field length, consider putting your logic in a script include. For example, rather than something like this...
current.active && current.canRead() && (current.state == 4 || current.state == 5 || current.state == 7) && (current.u_requester.department.getDisplayValue == 'Marketing' || current.u_requester.getDisplayValue() == 'HR') || gs.hasRole('admin')
It could look something like this:
new myConditionCheck().ApprovalUIAction(current);
and your script include becomes a thing of beauty to maintain and extend.
var myConditionCheck = Class.create();
myConditionCheck.prototype = {
initialize: function() {
},
ApprovalUIAction : function(gr) {
var isAdmin = gs.hasRole('admin');
var canRad = gr.canRead();
var isActive = gr.active;
var isGoodState = (gr.state == 4 || gr.state == 5 || gr.state == 7);
var dept = gr.u_requester.department.getDisplayValue();
var isGoodDept = (dept == 'Marketing' || dept == 'HR');
if (isActive && canRead && isGoodState && isGoodDept || isAdmin)
return true;
return false;
},
type: 'myConditionCheck'
};
Andrew and I covered this in our video a while back:
Script Includes
