Issues with comparing variable dates

[Moedeb]

I am trying to do something that I've seen a lot of posts on and I have not been able to get it to work.

I have two variables on a catalog item:

1. u_leave_date
2. u_return_date

Ultimately I'm just trying to check that the leave date is before the return date and if it isn't, clear the return date value and add a popup message advising the user.

This is the code I have in a catalog client script on the catalog item:

function onChange(control, oldValue, newValue, isLoading) {
    if (isLoading || newValue == '') {
        return;
    }

    //Type appropriate comment here, and begin script below
    var returndate = g_form.getDisplayValue('u_return_date');
    var leavedate = g_form.getDisplayValue('u_leave_date');
    var returndateValue = new Date(returndate).valueOf();
    var leavedateValue = new Date(leavedate).valueOf();

    if (leavedateValue > returndateValue) {
        alert("Return date must be after the departure date");

        g_form.setValue('u_return_date', '');
    }
}

Here is the catalog client script:

It is sort of working - but in reality it is just looking at the first part of the date and as long as the first number is higher in the leave date it will give the message and clear the value, if it is lower it just assumes it is correct.

IE: (date format dd/mm/yyyyy)

Leave date = 04/09/2024

Return date = 03/10/2024

- Because the 03 is before the 04 number wise it will popup advising 

"Return date must be after the departure date

Even though the return date is obviously after the leave date.

However in this scenario it doesn't at all object, because the first part of the dates has a higher number ie: 28 is higher than the 04 even though the month or even the year makes it an earlier date.

 

Leave date = 04/09/2024

Return date = 28/05/2023

Can someone fix my script please?

[HIROSHI SATOH]

I think this is fine

    // Parse the dates into JavaScript Date objects
    var leavedateValue = new Date(leavedate);
    var returndateValue = new Date(returndate);

[Moedeb]

@HIROSHI SATOH 

So not sure where you mean I should put those? But assumed they would at least replace these lines?

    var returndateValue = new Date(returndate).valueOf();
    var leavedateValue = new Date(leavedate).valueOf();

So I tried this:

function onChange(control, oldValue, newValue, isLoading) {
    if (isLoading || newValue == '') {
        return;
    }

    //Type appropriate comment here, and begin script below
    var returndate = g_form.getDisplayValue('u_return_date');
    var leavedate = g_form.getDisplayValue('u_leave_date');
    // Parse the dates into JavaScript Date objects
    var leavedateValue = new Date(leavedate);
    var returndateValue = new Date(returndate);

    if (leavedateValue > returndateValue) {
        alert("Return date must be after the departure date");

        g_form.setValue('u_return_date', '');
    }
}

Still does the same thing.

[HIROSHI SATOH]

Fixing the code

    var returndate = g_form.getDisplayValue('u_return_date');
    var leavedate = g_form.getDisplayValue('u_leave_date');
    var returndateValue = new Date(returndate).valueOf();
    var leavedateValue = new Date(leavedate).valueOf();

    // Get the values from the form
    var leavedate = g_form.getValue('u_leave_date');
    var returndate = g_form.getValue('u_return_date');

    // Parse the dates into JavaScript Date objects
    var leavedateValue = new Date(leavedate);
    var returndateValue = new Date(returndate);

Why not add a debug log to your code to see the values?

[Tai Vu]

Hi @Moedeb 

Have you given a try to the UI Policy? We can leverage the Condition Builder with easy configuration to compare date time between 2 variables. I'll check the script meanwhile.

Cheers,

Tai Vu