XML Parser - Script Include

littleericj
Tera Contributor

‎08-06-2024 10:05 AM

I'm trying to create a catalog item where a REST API function is called to reach out to a XML URL to return the names of the clusters and populate this info in a selectable select box so that the user can select one of the names from the drop down. 

 

My API Response message comes back with the correct data so I know that's working, but I think there's an issue with my script include: 

 

var WebSphereTopologyParser = Class.create();
WebSphereTopologyParser.prototype = {
    initialize: function() {},

    getClusterNames: function() {
        var restMessage = new sn_ws.RESTMessageV2('WebSphereTopologyXML', 'GetTopologyXML');
        var response = restMessage.execute();
        var responseBody = response.getBody();

        var parser = new XMLDocument2();
        parser.parseXML(responseBody);

        var clusters = parser.getNode('//cluster');
        var clusterNames = [];

        for (var i = 0; i < clusters.length; i++) {
            var cluster = clusters[i];
            if (!cluster.getAttribute('name').includes('Placeholder')) {
                clusterNames.push(cluster.getAttribute('name'));
            }
        }

        return JSON.stringify(clusterNames);
    },

    type: 'WebSphereTopologyParser'
};
 
Any idea what's wrong with my code? 
0 Helpfuls
  • 405 Views
1 REPLY 1

_paranthaman_
Tera Contributor

‎08-06-2024 11:12 PM

It looks like you’re on the right track with your script include, but there are a few adjustments needed to ensure it works correctly with your XML data. I assume your XML structure looks like this:

 

 

<?xml version="1.0" encoding="UTF-8"?>
<topology>
    <cluster name="ClusterA"/>
    <cluster name="ClusterB"/>
    <cluster name="ClusterPlaceholder"/>
    <cluster name="ClusterC"/>
</topology>

 

 

 

Based on this structure, here’s a refined version of your script that should address the issues:

 

 

 

var WebSphereTopologyParser = Class.create();
WebSphereTopologyParser.prototype = {
    initialize: function() {},

    getClusterNames: function() {
        var restMessage = new sn_ws.RESTMessageV2('WebSphereTopologyXML', 'GetTopologyXML');
        var response = restMessage.execute();
        var responseBody = response.getBody();

        var parser = new XMLDocument2();
        parser.parseXML(responseBody);

        var clusterNames = [];
        
        // Use a fixed range to avoid infinite loop
        for (var index = 1; index <= 10; index++) {
            var cluster = parser.getNode('/topology/cluster[' + index + ']');
            if (!cluster) break; // Exit loop if no more clusters
            
            var clusterName = cluster.getAttribute('name');
            if (clusterName && !clusterName.includes('Placeholder')) {
                clusterNames.push(clusterName);
            }
        }

        return JSON.stringify(clusterNames);
    },

    type: 'WebSphereTopologyParser'
};

 

 

 

Screenshot 2024-08-07 at 11.39.48 AM.png


Key Changes: 

  1. Fixed Iteration Range: Instead of using .length which can be problematic if the number of nodes is unknown, I’ve used a fixed range of 10 iterations. This avoids potential infinite loops and ensures that your script will not break if the number of clusters exceeds expectations.

  2. Node Retrieval: The parser.getNode('/topology/cluster[' + index + ']') approach allows us to retrieve nodes individually and check if they exist before processing them. This avoids issues if the XML structure changes or if there are fewer nodes than expected.

  3. Error Handling: The if (!cluster) break; condition ensures that we exit the loop once we no longer find clusters, making the script more robust.

These changes should help your script correctly parse the XML and extract the cluster names. Let me know if you need further assistance!

0 Helpfuls