I agree with previous posts, that your JavaScript code contains some errors. Missing declaration of i variable is one problem. Usage of indexOf method of emailText variable means that it should be probably string. Then you can use String(emailText) to make your code safer (String(emailText) is safer as emailText.toString() because it works even with null and undefined).
On the other side, I think that the main problem in your code is the following: the loop by i works only with i=0. After that it execute always return statement to exit from shouldSkipCaseCreation function. You can fix your code by removing else part of the if statement and placing return false; directly after the for-loop.
If we speak about JavaScript, then I would recommend you to use some helpful functions of Array, which supported by ServiceNow in both server and client code: some, every and forEach. forEach can be used if you need to do some actions or tests with every element of array. some and every functions are helpful in case of testing elements of array (like in your case). If you need be sure that some condition if true with all element of array then it's good to use every method and in your case, if you need find at least one element of the array, which correspond the condition, the usage of some method would be good.
Thus, I'd suggest you to modify your code to the following:
/* global Class */
var CFSInboundEmailUtil = Class.create();
CFSInboundEmailUtil.prototype = {
initialize: function () {
//this.keywordProperty = JSON.stringify(gs.getProperty("sn_hr_core.cfs.esc.keywords", "[]"));
//this.keywordProperty = gs.getProperty("sn_hr_core.cfs.esc.keywords", "").split(";");
this.keywordProperty = ["AIT Application", "Open Enrollment", "PlanSource",
"Plan Source", "Sellback", "Hire Date Change", "Employee Deletion"];
},
shouldSkipCaseCreation: function (emailText) {
// returns true if the subject contains text that indicates the email should not creare a case
emailText = String(emailText);
return this.keywordProperty.some(function (keyword) {
return emailText.indexOf(keyword) > -1;
});
},
type: "CFSInboundEmailUtil"
};
If you would fill keywordProperty from property "sn_hr_core.cfs.esc.keywords" (which I don't know) then you should not forget that gs.getProperty("sn_hr_core.cfs.esc.keywords") can return null (if the property doesn't exist) and the returned value will be probably string and not array. Thus you will need to use split method additionally or JSON.parse to convert the value to array. Thus, I'd recommend you to use the second parameter of gs.getProperty as "" or "[]" depend on which method you will use for converting the value to array.
