why in onSubmit() client script, Return false is not working in Service Portal?

Go to solution
Anand Shukla
Mega Guru

‎03-07-2022 12:32 AM

Hi Experts,

I am trying to validate some fields using glide ajax but return false is not working  alert is working.

Could you please help me with this?

After validation alert is showing but form gets submitted.

function onSubmit() {
	
  var ga = new GlideAjax('getUserdetails');
    ga.addParam('sysparm_name', 'getUserInformation');
    ga.addParam('sysparm_user_id', g_form.getValue('caller_name'));
    ga.getXML(parseUserResponse);

    function parseUserResponse(response) {
         var answer = response.responseXML.documentElement.getAttribute("answer");

    if (answer == 'Contractor') {

        if (g_form.getValue('work_in_china_or_russia') != 'No') {

            alert('Please Select all questions without any Error of Contractor form');
            return false;


        }
	}
    }
}
Labels:
0 Helpfuls
  • 6,644 Views
1 ACCEPTED SOLUTION

Go to solution
Ankur Bawiskar
Tera Patron
Tera Patron
In response to Anand Shukla

‎03-07-2022 01:12 AM

Hi,

then take this approach

I assume your called name is readonly once it gets auto-populated with logged in user and is not changed.

1) create string variable with name as Employment Type (employment_type) and hide it always using UI policy; keep it at the bottom of the form

2) then in default value of that variable use this to store the employment type

javascript:

var typ;
var user_sys_id = gs.getUserID(); // always logged in user
var user = new GlideRecord('sys_user');
user.addQuery('sys_id',user_sys_id);
user.query();
if (user.next()) {
typ = user.u_employment_type;
}
typ;

3) use this in your onSubmit and compare value stored in hidden variable

function onSubmit() {

	var answer = g_form.getValue('employment_type');
	if (answer == 'Contractor') {
		if (g_form.getValue('work_in_china_or_russia') != 'No') {
			alert('Please Select all questions without any Error of Contractor form');
			return false;
		}
	}
}

Regards
Ankur

Regards,
Ankur
✨ Certified Technical Architect  ||  ✨ 9x ServiceNow MVP  ||  ✨ ServiceNow Community Leader

View solution in original post

11 REPLIES 11

Go to solution
Raghu Ram Y
Kilo Sage

‎03-07-2022 01:01 AM

Hi @Anand Shukla 

If you want to set caller name to loggedin user, then navigate to the variable and in default value use this..

javascript:gs.getUserID() and make the field to readonly.

 

0 Helpfuls

Go to solution
Vishnu Prasad K
Giga Guru

‎03-07-2022 01:19 AM

Hi Anand,

 

When you are using GlideAjax in an onSubmit client script, the form submit action will be already done before the GlideAjax returns the result. It's not a synchronous call. System will take some time to return the results through GlideAjax.

Since it's a field validation, better to use an onChange client script.

You can also use getXMLWait(), but it's not at all recommended, since it will cause delay in loading the form

0 Helpfuls