Hi All,
As @Barry Kant pointed out (thanks again!) I have confirmed that it is indeed the ServiceSubscriptionUtils script, not the SPMSubscriptionUtils script, that is being executed when evaluating which Catalog Items are visible to users based on the Offering Subscriptions. Furthermore, I have validated that you can indeed modify this script to that it will include all parent locations of the user's Location, which avoids the need to individually subscribe every child location at the Offering level.
Here is the code change needed to subscribe Locations recursively:
Here is the modified _addLocation function:
_addLocation: function(answer, location_id) {
var gr = new GlideRecord(this.constants.SERVICE_SUBSCRIBE_LOCATION);
var qry = gr.addQuery('cmn_location', location_id);
//FIX for recursive subscription: add parent locations
var grLoc = new GlideRecord('cmn_location');
while (!gs.nil(location_id)) {
if (grLoc.get(location_id)) {
location_id = grLoc.getValue('parent');
if (!gs.nil(location_id)) {
qry.addOrCondition('cmn_location', location_id);
}
}
}
this._query(gr, answer);
},
IMPORTANT: When testing this change, clear your server and browser cache before testing the results or else you may not see the change occur!
You can follow the same approach to recursively subscribe to Companies, Departments, and Groups as well.
@marcguegueniat (and others) please try this out and mark this as a Solution if this works for you. And if it doesn't, let me know because I'd love to see this through to resolution!
My findings during testing were the same, that child locations are not included in the subscribed users. One thing I will note here is that during testing I also found that I had to flush the server cache with cache.do every time I made a change to the subscriptions, which led me astray in my findings several times if I forgot to do this.
The script include for this does not support including hierarchical Companies, Departments, or Groups. You would need to either modify the OOB script include SPMSubscriptionUtils to traverse the hierarchy and include all users recursively, or build a business rule to cascade this down to automatically add child objects to the subscriptions. In my opinion the former is a better solution, since the latter solution would mean that your subscriptions would need to be removed and recreated whenever you have an organizational change. [UPDATE: See the later posts below; this script is used not for determining catalog item visibility for the logged on user but for other purposes.]
However, when you actually look at the code, it appears that Locations are recursive. For some reason it does not appear to be working that way, so there may be a bug in the OOB script include that hasn't been uncovered yet. Up to now I had assumed the same issue existed for subscribed Locations as the issues that exist for the other subscriptions, but as you can see below, this appears to have been designed to include recursive locations.
