Called Client Script Returning Undefined

[Marc D]

Hello, everyone.  I'm having an issue with an implementation of a solution for my client.

I have been tasked for a form to compare the company of a user on the form with another company listed on the form itself, and to make certain fields read-only if they are identical. This is in and of itself fairly simple - a GlideAjax call.

However, I have to use this same functionality multiple times over multiple Client Scripts, and to cut down on the same GlideAjax call being written repeatedly, I placed it within a function within a separate Client Script and had my main Client Scripts call this function.

This is how it looks:

Script Include:

getUserCompany: function() {
	var userID = this.getParameter('sysparm_userid');

        if (userID != "") {
            var userGr = new GlideRecord("sys_user");
            if (userGr.get(userID)) {
			   var res = userGr.company;
			   return res;
		    }
         }
     return "";
}

Callable Client Script:

userCompanyCheck = function() {
    var user = g_form.getValue('form_user');
    var company = g_form.getValue('form_company');

    var userCompany = new GlideAjax('<Script Include Name>');
    userCompany.addParam('sysparm_name', 'getUserCompany');
    userCompany.addParam('sysparm_userid', user);
    userCompany.getXML(compareCompany);

    function compareCompany(response) {
        var answer = response.responseXML.documentElement.getAttribute("answer");
        if (answer != company) {
            return 'false';
        } else {
            return 'true';
        }
    }
};

Main Client Script:

var userHasSameCompany = userCompanyCheck();
if (userHasSameCompany == 'true') {
        g_form.setValue('internal_comparison_flag', 'No');
} else {
        g_form.setValue('internal_comparison_flag', 'Yes');
}

But there's an issue with this: in the main Client Script, userHasSameCompany ALWAYS returns "undefined" from userCompanyCheck(), regardless of whether or not it returned "true" or "false", and I have checked - it has reached both.

What is the problem with my implementation? Did I do something wrong?

[k_lutz]

Hello @Marc D 

I think you code just needs a tweak as it sounds a bit like a timing issue because of the overall structure. Can you try something like this for your main script:

userCompanyCheck(function(isSameCompany) {
if (isSameCompany) {
g_form.setValue('internal_comparison_flag', 'No');
} else {
g_form.setValue('internal_comparison_flag', 'Yes');
}
});

And then in your client script:

function userCompanyCheck(done) {
var user = g_form.getValue('form_user');
var company = g_form.getValue('form_company');

var ga = new GlideAjax('<Script Include Name>');
ga.addParam('sysparm_name', 'getUserCompany');
ga.addParam('sysparm_userid', user);

ga.getXMLAnswer(function(answer) {
// answer will be the sys_id of the company reference (usually)
var isSameCompany = (answer === company);
done(isSameCompany);
});
}

You will need to provide the name of your script include and make sure it is client callable.

[Marc D]

This sounds like it might work, as some of the debugging I have done is suggesting the getXML function isn't being resolved right away, but

EDIT: This post has been edited as the user confused getXMLAnswer with getXMLWait

[k_lutz]

Hi @Marc D 

Can you try something like this?

function userCompanyCheck(done) {
var user = g_form.getValue('form_user');
var company = g_form.getValue('form_company');

var ga = new GlideAjax('<Script Include Name>');
ga.addParam('sysparm_name', 'getUserCompany');
ga.addParam('sysparm_userid', user);

ga.getXML(function(response) {
var answer = response.responseXML.documentElement.getAttribute('answer');
done(answer === company); // boolean
});
}

userCompanyCheck(function(isSameCompany) {
g_form.setValue('internal_comparison_flag', isSameCompany ? 'No' : 'Yes');
});

Also in your script include you may want to adjust to:

return userGr.getValue('company');

Just want to make sure on both sides you are comparing the sys_ids which I think is your plan.

[Marc D]

Hello, k_lutz. First off, I would like to apologize for my first response - I had confused getXMLAnswer with getXMLWait - it's the latter that's not supported and doesn't work in Service Portal.

That being said, I have tried both implementations you have suggested, the getXMLAnswer and getXML, and neither worked.

I would like to make one little correction on my part, however - I am not actually using the internal Company field for this requirement. I am using a custom-defined String field. I only referred to it as Company for privacy reasons. I should have been more forthright.