Glideform query

[keep_it_simple]

Can someone please tell me what is wrong with the below code

function onLoad() {

    var gr = new GlideRecord("incident");

    var x = gr.getNumber("number","INC0000031");  # this incident exists 

    if(x.isValidRecord())

    {

    g_form.setValue('impact',"3");

    }

}

[Prashanth redd4 · Accepted solution]

The GlideRecord method is no longer recommended due to its performance impact. it retrieves all fields in the requested GlideRecord when most cases only require one field. Instead, use g_scratchpad on a display business rule or use GlideAjax methods.

[Amit Pandey · Accepted solution]

Hi @keep_it_simple 

I am not sure of .getNumber. Instead you should use addQuery() or addEncodedQuery(). Please try following code-

function onLoad() {
    var gr = new GlideRecord("incident");
    gr.addQuery("number", "INC0000031");
    gr.query();
    if (gr.next()) {
        g_form.setValue('impact', "3");
    }
}

Please mark my answer helpful and correct.

Regards,

Amit

[Naomi5 · Accepted solution]

Amit, 

Great response. Came here to say exactly this. 

Also https://www.youtube.com/watch?v=H_eoB6LXPrs

Here's a video on why variables shouldn't be named gr

[Harish KM · Accepted solution]

Hi @keep_it_simple you cannot use glide record query in client side scripts, convert them to script include and use glide ajax to call,

Also you cannot compare with number compare with sysid instead.

Example: create a client callable script include

Script Include:

 checkRecord: function() {

        var recSysId= this.getParameter('sysparm_sysid'); // get sysid of record from client script

        var rec = new GlideRecord('incident');

       rec.get(recSysId);

        rec.query();

// valid record?

        if (rec.isValidRecord()) {

            return true;

        }

        return false;

    },

onload client script:

 var recSysID= g_form.getValue('variablename');

    var ga = new GlideAjax('scriptincludename'); // pass your script include name here

    ga.addParam('sysparm_name', 'checkRecord');//function name used in script include

    ga.addParam('sysparm_sysid', recSysID);

    ga.getXMLAnswer(response);

    function response(answer)

    {

    if (answer == true) {

g_form.setValue('impact',"3");

    } else {

        g_form.setValue('impact',"1");

    }

}

[Prashanth redd4 · Accepted solution]

The GlideRecord method is no longer recommended due to its performance impact. it retrieves all fields in the requested GlideRecord when most cases only require one field. Instead, use g_scratchpad on a display business rule or use GlideAjax methods.

[Amit Pandey · Accepted solution]

Hi @keep_it_simple 

I am not sure of .getNumber. Instead you should use addQuery() or addEncodedQuery(). Please try following code-

function onLoad() {
    var gr = new GlideRecord("incident");
    gr.addQuery("number", "INC0000031");
    gr.query();
    if (gr.next()) {
        g_form.setValue('impact', "3");
    }
}

Please mark my answer helpful and correct.

Regards,

Amit

[Naomi5 · Accepted solution]

Amit, 

Great response. Came here to say exactly this. 

Also https://www.youtube.com/watch?v=H_eoB6LXPrs

Here's a video on why variables shouldn't be named gr

[Harish KM · Accepted solution]

Hi @keep_it_simple you cannot use glide record query in client side scripts, convert them to script include and use glide ajax to call,

Also you cannot compare with number compare with sysid instead.

Example: create a client callable script include

Script Include:

 checkRecord: function() {

        var recSysId= this.getParameter('sysparm_sysid'); // get sysid of record from client script

        var rec = new GlideRecord('incident');

       rec.get(recSysId);

        rec.query();

// valid record?

        if (rec.isValidRecord()) {

            return true;

        }

        return false;

    },

onload client script:

 var recSysID= g_form.getValue('variablename');

    var ga = new GlideAjax('scriptincludename'); // pass your script include name here

    ga.addParam('sysparm_name', 'checkRecord');//function name used in script include

    ga.addParam('sysparm_sysid', recSysID);

    ga.getXMLAnswer(response);

    function response(answer)

    {

    if (answer == true) {

g_form.setValue('impact',"3");

    } else {

        g_form.setValue('impact',"1");

    }

}