Quick help with adding users from an array to a group

[Brendan Hallida]

Hi all,

I am pretty sure that I am close, however, the script is not running for all users in the array.

This is what I have so far:

var admins = ["user1","user2"]; //array
for(var i = 0; i < admins.length; i++) //for loop
   {
var gr = new GlideRecord('sys_user_grmember');
gr.initialize();
gr.user = admins[i];
gr.group.setDisplayValue('Admin') 
gr.setWorkflow(false);
gs.print(gr.insert());
}

So the script adds user1 to the group, and then also adds a blank entry in the user list of the group

anyone know what I'm missing?

Thanks, Brendan

[Dubz]

there's a rogue apostrophe after the admins[i]. Change to this:

gr.addEncodedQuery('user.name=' + admins[i] + '^group.name=Admin');

[Brendan Hallida]

Cheers, the query is fixed, however, it is still adding the users.

Interestingly, when running from background scripts - the message after running it is different when running it when the users are already in the group.

when they are not in the group:

Adding Role admin to user1
Background message, type:info, message: Adding Role admin to user1
*** Script: 7e2de14adb0ce700ce49aaf6059619e2
Adding Role admin to user2
Background message, type:info, message: Adding Role admin to user2
*** Script: b62da54adb0ce700ce49aaf60596192d

when they are in the group:

*** Script: 457de546db0ce700ce49aaf6059619ec
*** Script: 857de546db0ce700ce49aaf6059619ee

[Dubz]

just tested on my PDI as below. The users were added first time around and ignored thereafter. Add a couple of debug lines as below to confirm what the hasNext is returning and if the condition is passing. 

For the record, i tested without lines 4-8 and users still weren't added to the group as they already existed there. Do the users in your admins array already exist in the user table?

var admins = ["Aileen Mottern","Alejandro Mascall"];
for(var i = 0; i < admins.length; i++) {
var gr = new GlideRecord('sys_user_grmember');
gr.addEncodedQuery('user.name=' + admins[i] + '^group.name=Service Desk');
gr.query();
gs.print(gr.hasNext());
if(!gr.hasNext()){
gs.print('adding users');
gr.initialize();
gr.user.setDisplayValue(admins[i]);
gr.group.setDisplayValue('Service Desk') ;
gr.setWorkflow(false);
gs.print(gr.insert());
}
}

[Brendan Hallida]

ok i think I know what the issue is.  I was using username in the array, not name.

how can we use username?  its not the end of the world if we cant, but would be nice.

[Chuck Tomasi]

If you want to use the "User ID" (user_name) field, then it would look like this: (note, this code has not been tested.)

var admins = ["aileen.mottern","alejandro.mascall"];
for(var i = 0; i < admins.length; i++) {
  var gr = new GlideRecord('sys_user_grmember');
  gr.addEncodedQuery('user.user_name=' + admins[i] + '^group.name=Service Desk');
  gr.query();
  gs.debug(gr.hasNext());
  if (!gr.hasNext()){
    // try to get the user record by user_name to track the sys_id
    var usrGr = new GlideRecord('sys_user');
    if (!usrGr.get('user_name', admins[i])) {
      // User not found by user_name
      gs.error('Cannot find user: ' + admins[i]);
      continue;
    }

    // Now build the new record in sys_user_grmember
    var memGr = new GlideRecord('sys_user_grmember');
    gs.debug('adding users');
    memGr.newRecord();
    memGr.user = usrGr.getValue('sys_id');
    memGr.group.setDisplayValue('Service Desk') ;
    memGr.setWorkflow(false);
    gs.debug(gr.insert());
  }
}