State not updating in UI Action

JennieD1 · ‎10-02-2023

Hi there! I have a business requirement for a form to have a button to change the state based on two conditions. 1. The form must have an attachment and 2. The form must have two mandatory questions answered. This application is in a scoped app. Thus far, I have created a UI Action and a script include. The logic I have works whenever I start a new record. My problem is, if I save a record and answer one of the conditions, but not the other, it is going ahead and updating the state. Can anyone help me with this?

As you can see in the below image, my state has updated from open to work in progress, but only the attachment condition has been fulfilled. The 'Created & Assigned' and 'Test Fields' should still be mandatory and the state should still be open.

UI Action

function changeState() {
     var ga = new GlideAjax("x_755950_disclos_0.getAttachmentsDisclosure");
     ga.addParam('sysparm_name', 'checkAttachment');
     ga.addParam('sysparm_sysID', g_form.getUniqueValue());
     ga.addParam('sysparm_tableName', g_form.getTableName());
     ga.getXML(validateForm);

     function validateForm(response) {
         var answer = response.responseXML.documentElement.getAttribute("answer");
         if (answer == "false") {
             g_form.addErrorMessage("You need to add an attachment");
             g_form.setMandatory('u_create_and_assigned', true);
             g_form.hideFieldMsg('u_create_and_assigned');
             g_form.showFieldMsg('u_create_and_assigned', "Please select an answer before changing the state.");
             g_form.setMandatory('test_field', true);
             g_form.hideFieldMsg('test_field');
             g_form.showFieldMsg('test_field', "Please select an answer before changing the state.");
         } else {
             g_form.setValue('state', 2);
             g_form.setMandatory('u_create_and_assigned', false);
             g_form.setMandatory('test_field', false);

         }

     }


     // gsftSubmit(null, g_form.getFormElement(), 'check_fields');
 }

Script Include:

var getAttachmentsDisclosure = Class.create();
getAttachmentsDisclosure.prototype = Object.extendsObject(global.AbstractAjaxProcessor, {

checkAttachment: function() {
    var sysID = this.getParameter('sysparm_sysID');
    var tableName = this.getParameter('sysparm_tableName');
    var attachment = new GlideSysAttachment();
    var agr = attachment.getAttachments(tableName, sysID);
    if (agr.next()) {
        return true;
    } else {
        return false;
    }
    },
    type: 'getAttachmentsDisclosure'

});

MackI · ‎10-02-2023

function changeState() {
    var attachmentConditionMet = false;
    var mandatoryFieldsConditionMet = false;

    // Check the attachment condition
    var ga = new GlideAjax("x_755950_disclos_0.getAttachmentsDisclosure");
    ga.addParam('sysparm_name', 'checkAttachment');
    ga.addParam('sysparm_sysID', g_form.getUniqueValue());
    ga.addParam('sysparm_tableName', g_form.getTableName());
    ga.getXML(function (response) {
        var answer = response.responseXML.documentElement.getAttribute("answer");
        if (answer == "false") {
            g_form.addErrorMessage("You need to add an attachment");
        } else {
            attachmentConditionMet = true;
            checkAndUpdateState();
        }
    });

    // Check the mandatory fields condition
    var uCreateAndAssignedValue = g_form.getValue('u_create_and_assigned');
    var testFieldValue = g_form.getValue('test_field');
    
    if (!uCreateAndAssignedValue || !testFieldValue) {
        g_form.addErrorMessage("Please answer both mandatory questions");
    } else {
        mandatoryFieldsConditionMet = true;
        checkAndUpdateState();
    }

    function checkAndUpdateState() {
        if (attachmentConditionMet && mandatoryFieldsConditionMet) {
            // Both conditions are met, change the state
            g_form.setValue('state', 2);
            g_form.setMandatory('u_create_and_assigned', false);
            g_form.setMandatory('test_field', false);
        } else {
            // At least one condition is not met, do not change the state
            g_form.setValue('state', 1); // Set the state back to 'Open' if needed
            g_form.setMandatory('u_create_and_assigned', true);
            g_form.setMandatory('test_field', true);
        }
    }
}

Let me know if the above things works ...

MackI | ServiceNow Developer | 2 *Mainline Certification | LinkedIn Top IT Operation Voice 2023 | Sydney,Australia

View solution in original post

JennieD1 · ‎10-02-2023

 function changeState() {
     var ga = new GlideAjax("x_755950_disclos_0.getAttachmentsDisclosure");
     ga.addParam('sysparm_name', 'checkAttachment');
     ga.addParam('sysparm_sysID', g_form.getUniqueValue());
     ga.addParam('sysparm_tableName', g_form.getTableName());
     ga.getXML(validateForm);

     function validateForm(response) {
         var answer = response.responseXML.documentElement.getAttribute("answer");
         if (answer == 'false' && (g_form.getValue('u_create_and_assigned') == '' || g_form.getValue('test_field') == '')) {

             g_form.addErrorMessage("You need to add an attachment");
             g_form.setMandatory('u_create_and_assigned', true);
             g_form.hideFieldMsg('u_create_and_assigned');
             g_form.showFieldMsg('u_create_and_assigned', "Please select an answer before changing the state.");

             g_form.setMandatory('test_field', true);
             g_form.hideFieldMsg('test_field');
             g_form.showFieldMsg('test_field', "Please select an answer before changing the state.");
            
         } else {
             g_form.setValue('state', 2);
             g_form.setMandatory('u_create_and_assigned', false);
             g_form.setMandatory('test_field', false);

         }

     }


     // gsftSubmit(null, g_form.getFormElement(), 'check_fields');
 }

So when I add the quotes back to the false in my if statement, it works on the mandatory fields, but it is now not working for the attachment condition.

Peter Bodelier · ‎10-02-2023

Can you add a line in between, and share what the popup says?

 var answer = response.responseXML.documentElement.getAttribute("answer");

alert(answer)

         if (answer == 'false' && (g_form.getValue('u_create_and_assigned') == '' || g_form.getValue('test_field') == '')) {

Help others to find a correct solution by marking the appropriate response as accepted solution and helpful.

JennieD1 · ‎10-02-2023

Here is the alert with both conditions not met.

Here is the pop up with only the attachment condition

But it updated the state and it should not have because my second condition was not met.

Danish Bhairag2 · ‎10-02-2023

along with your answer in your If statement u also need to check for those fields whether they are filled or not something like below

if(answer == false && (g_form.getValue('create_and_assigned') == '' || g_form.getValue('test') == '')){
//place your logic
}

Please mark my answer helpful & accepted if it helps you resolve your query.

Thanks,

Danish

JennieD1 · ‎10-02-2023

Nope, nothing. And it I remove the attachment and put both mandatory fields back to '', and hit the ui action button it changes the state even though none of the conditions are met.