User with admin role still see the Cancel Change button even the condition stated specific access

[bbf35621]

Hello folks,

I got a requirement to add conditions for the OOTB UI action called Cancel Change. The requirements are only assigned to group users, or a user who has a change_manager role can see cancel change. I have added in UI action condition,

gs.getUser().isMemberOf(current.assignment_group) || gs.getUser().hasRole('change_manager') && new ChangeFormUI(current).isCancelAvailable()

The conditions work for non-admin users but the admin users who are not assigned to a group or have change_manager role are still able to see the Cancel Change button. How can I prevent admin users from seeing this button?

[Brad Bowman · Accepted solution]

hasRole always returns true for admins.  Try this approach instead:

(gs.getUser().isMemberOf(current.assignment_group) || gs.getSession().getRoles().indexOf('change_manager') >-1) && new ChangeFormUI(current).isCancelAvailable()

The parenthesis around the OR condition ensures there's no mis-interpretation of order/priority

[bbf35621]

That solved my issue! Thanks!

[Brad Bowman]

You are welcome!

[Mayur2109]

Hi @bbf35621 ,

You can add extra condition for restricting button to admins as;

gs.hasRole('itil,sn_change_write') && new ChangeFormUI(current).isCancelAvailable() && !gs.hasRole('admin')

Please check and Mark Helpful and Correct if it really helps you.

Regards,
Mayur Shardul

ServiceNow Rising Star 2024