Alternative for DOM Manipulation in client script

[kavitha_cr]

Hi All,

I am using the below code in a Onsubmit catalog client script to show an alert for attaching a file before submitting the ticket in the portal.

Script:

function onSubmit() {
try { //Works in non-portal ui
var attachments = document.getElementById('header_attachment_list_label'); //Line3
if (attachments.style.visibility == 'hidden' || attachments.style.display == 'none' ) {
alert("Please attach file before submitting.");
return false;
}
} catch(e) { //For Service Portal
var count = getSCAttachmentCount();
if(count <= 0) {
alert("Please attach file before submitting.");
return false;
}
}
}

According to Best Practice, we will not be using DOM manipulation , so I need to replace the code. Can I get the alternative solution for the line 3 in the above script by not breaking the existing functionality.

Thanks in Advance,

Shilpa.

[Ankur Bawiskar]

Hi,

like this

function onLoad() {
	//Populate the variables with the parameters passed in the URL
	//Use the 'getParmVal' function below to get the parameter values from the URL

	var glideURL = new GlideURL();
	glideURL.setFromCurrent();

	var sd = glideURL.getParam('sysparm_short_descr');
	var ds = glideURL.getParam('sysparm_full_descr');

	g_form.setValue('short_descr',sd);
	g_form.setValue('full_descr',ds);

}

Regards
Ankur

[kavitha_cr]

Thank you Ankur.

[kavitha_cr]

Hi @Ankur Bawiskar ,

I have one more question if u can answer..

which code can I replace the below bold code.(we should not use DOM)

function onChange(control, oldValue, newValue, isLoading) {
if (isLoading || newValue == '') {
return;
}

CustomEvent.fire('OA-DatacenterAssetsDecomm-checkServersInCMDB', {serverNameList: newValue, g_form: g_form});

}

Thanks,

Shilpa.

[Ankur Bawiskar]

Hi,

can you share your final script which doesn't use DOM for mandatory attachment which works in native + portal

Regards
Ankur

[kavitha_cr]

Hi @Ankur Bawiskar ,

Sure. Below is the code.

function onSubmit() {
try { //Works in non-portal ui
var attachments = g_form.getFormElement('header_attachment_list_label');
('header_attachment_list_label');
if (attachments.style.visibility == 'hidden' || attachments.style.display == 'none' ) {
alert('Please attach the requested form before submitting.');
return false;
}
} catch(e) { //For Service Portal
var count = getSCAttachmentCount();
if(count <= 0) {
alert('Please attach the requested form before submitting.');
return false;
}
}
}

Thanks,

Shilpa.