Get the Approver of a RITM populated into a Catalog Item variable

[Basim Zaidi]

Hi Community,

I am trying to populate a variable on a Catalog Item with the Approver of a RITM that is being selected via another variable.  When selecting the RITM via the 'Request Item' variable (variable name is 'request_item' and variable is a reference to sysapproval_approver table), I would like the 'Current approver' variable (variable name is 'current_approver') to be populated with the Approver of the associated request item approval record.

I can do this via the following Catalog Client Script, however this does not work on the Service Portal.

function onChange(control, oldValue, newValue, isLoading) {
   if (isLoading || newValue == '') {
      return;
   }
	
	var gr = g_form.getReference('request_item');
	
	g_form.setValue('current_approver', gr.approver);
}

I therefore believe that I need a Script Include and call this in the Catalog Client Script, however I am struggling to get this to work!

Any help would be greatly appreciated!

Thanks,

Bas

[Basim Zaidi]

Yes, exactly line for line. In the example provided you have used exactly the same variable names as me. I've tried it in my personal dev instance as well as the company's - both come back undefined. What am I doing differently to you?

[Brent Sutton]

I just retested in my developer instance and everything is working fine.

Stupid question but I wanted to check that you've got the onChange Client Script running on the "request_item" variable? newValue will only contain the correct sys_id if triggered by the "request_item" variable.

Otherwise I'm at a loss. Like I said everything is working correctly in my developer instance.

Brent

[Brent Sutton · Accepted solution]

Okay worked out the issue.

Your reference variable "request_item" is on the sysapproval_approver table rather than the sc_req_item table that my script was expecting.

In your scenario there will only be ever one approver returned as a single approver is only ever assigned to each sysapproval_approver record.

Set up your "request_item" variable conditions and attributes as follows:

Conditions (restrict results to sc_req_item table and only show approvals that have been "Requested")

Attributes (show the approver column when searching)

It would also be worthwhile adding the approver to the list layout of the search list.

Select search icon >> List Layout >> Select Approver column to move to right >> Save

The approver will now show in the list view along with the approval for reference.

In this scenario I would question why you still need to populate the approvers name into a separate variable?

However, if you do need this then the following code should work for you:

Client Script:

NOTE: Your scenario does not actually need an array but I've left the logic in the script encase your use case changes. 

function onChange(control, oldValue, newValue, isLoading) {
	if (isLoading) {}

	if (newValue != '') {
		if (newValue != oldValue) {
			var ga = new GlideAjax("ApprovalAJAXUtils");
			ga.addParam("sysparm_name", "ritmApproversHandler");
			ga.addParam("sysparm_approvalSysId", newValue);
			ga.getXMLAnswer(processAnswer);
		}
	}
	else
		g_form.clearValue("current_approver");

	function processAnswer(answer) {
		if (answer) {
			var approversInfo = JSON.parse(answer);
			var approvers = "";

			for (var i=0; i< approversInfo.length; i++) {
				if (i === 0) {
					approvers = approversInfo[i].display_value;
				}
				else
					approvers += ", " + approversInfo[i].display_value;
			}
			g_form.setValue("current_approver",approvers);
		}
	}
}

Script Include:

var ApprovalAJAXUtils = Class.create();
ApprovalAJAXUtils.prototype = Object.extendsObject(AbstractAjaxProcessor, {

	ritmApproversHandler : function() {
		var approvalSysId = this.getParameter("sysparm_approvalSysId");
		answer = this.getApprovers(approvalSysId); //call getApprovers to return an array off approvers
		
		return JSON.stringify(answer);
	},

	getApprovers : function(input) {
		var gr = new GlideRecord("sysapproval_approver");

		var approvers = []; //set an array to hold the results

		if (gr.get(input)) {
			//add desired attributes to the object
			var approver = {
				value : gr.approver.getValue(), //sys_id of user
				display_value: gr.approver.getDisplayValue(), //display value for approver i.e. readable name
				email: gr.approver.email.getValue() //email addrees or whatever else you want to return
			};
			approvers.push(approver); //push object to array.
		}
		
		return approvers;
	},

	type: 'ApprovalAJAXUtils'
});

Hopefully this works for you.

Brent

P.S. If my suggestion helped then please mark as helpful and/or correct so other community members can benefit from this information.

[Basim Zaidi]

Brilliant Brent - thank you - works a treat!

[Omkar Mone]

Hi 

Just try this once :-

var grApproval = new GlideRecord('sysapproval_approver');


grApproval.addQuery('sysapproval.number',current.number);


grApproval.addQuery('state','approved');


grApproval.query();


if(grApproval.next())


{


       current.variables.smart_approval = 'Approved by' + grApproval.approver.name;


}