Transform Script to show active/inactive users.

[Andrew112]

Hello, I have a transform script on a table transform map that I want to go through all the users, initially set to inactive, and then set to active to make sure that only active users are in the User table everytime the User list is loaded from external source. (It is loaded every day at a set time)

I have the following: 

onStart 

(function runTransformScript(source, map, log, target /*undefined onStart*/ ) {

var users = new GlideRecord('sys_user');
users.query();
var user = users.next();
while(user !== null){
	user.Active = false;
	user = users.next();
}
})(source, map, log, target);

onAfter

(function runTransformScript(source, map, log, target /*undefined onStart*/ ) {

target.Active = true;

})(source, map, log, target);

It has been 1.5 hours, and it is still running. 

Is there any better way to accomplish what I am trying to do here?

[Michael Jones -]

So, your first step is to set ALL user records to inactive, and then only if they are in your import, set the to active? It's an unusual requirement but; you can gain some efficiency using updateMultiple() instead of a while loop. 

Be sure to try this out in a Dev instance! You might also want to...exclude your admin users. Just a thought. 

(function runTransformScript(source, map, log, target /*undefined onStart*/ ) {

var users = new GlideRecord('sys_user');
users.query();
//Note, always use setValue with updateMultiple!!!
users.setValue('active', false);
users.updateMultiple();


})(source, map, log, target);

If this was helpful or correct, please be kind and click appropriately!

Michael Jones - Proud member of the CloudPires Team!

[Andrew112]

Thanks for the help, so this will work?  (We actually have inactive users OK to login we disabled the business rule...)  I am testing in DEV, but it will probably be tomorrow until I can see if it works or not.

(function runTransformScript(source, map, log, target /*undefined onStart*/ ) {

if (!gs.hasRole("admin")){
var users = new GlideRecord('sys_user');
users.query();
//Note, always use setValue with updateMultiple!!!
users.setValue('active', false);
users.updateMultiple();

}
})(source, map, log, target);

[Ankur Bawiskar]

Hi,

corrections to your script

you are using incorrect field name for active at both the places

Test it for some records by adding setLimit() then remove this

onStart

(function runTransformScript(source, map, log, target /*undefined onStart*/ ) {

var users = new GlideRecord('sys_user');
users.setLimit(5); // for testing purpose
users.query();
while(users.next()){
	users.active = false;
	users.update();
}

})(source, map, log, target);

onAfter;

(function runTransformScript(source, map, log, target /*undefined onStart*/ ) {

target.active = true;

})(source, map, log, target);

Mark ✅ Correct if this solves your issue and also mark 👍 Helpful if you find my response worthy based on the impact.
Thanks
Ankur

[Andrew112]

Yeah but I am using updatemultiple instead of the while let me see if this works, then I'll try yours.