Business Rule to Assign Role on Insert into sys_user table with conditions

[Scott Megargee]

I have a request alter code for assigning as specific role to a user when inserted into the sys_user table. My current code works as expected but it's applying to "all users" inserted and now I need it to filter out specific records.

Current Code:

(function executeRule(current, previous /*null when async*/) {

var appRole = new GlideRecord('sys_user_has_role');
appRole.initialize();
appRole.user = current.sys_id;
appRole.role = 'sys_id_of_role'; // role sys_id for xyz appRole.insert();

})(current, previous);

I need this to filter out users where -

1. sys_user - Employee number is not empty, and Class is User

2. sys_user_group - User is not a member of xyz group. 

How can I incorporate these requirements into my current code? 

[Mark Roethof]

Hi there,

Don't see a reason why to change your code.

Have you looked at changing the conditions?

[Scott Megargee]

Basically, I only want to run the code if a record inserted into sys user table meets the new conditions I noted. I don't really have a lot of flexibility when it comes to changing the conditions/requirements for when the code should run. 

[Mark Roethof]

I don't understand, why wouldn't you have flexibility in changing the conditions of the business rule? That would even be a best practice, over doing such in your script since your script would simply trigger unnecessary.

[Mark Roethof]

You might also consider newer techniques for requirements like these... Flow Designer. Zero code involved when I look at what you are asking.