OnChange Client Script - Is there a more efficient way to script this

[Damian Mudge]

My first attempt at scripting, so be gentle!

The business scenario is we want to identify the the Operational Teams area based on the "Category" selected. I am testing ths in my PDI and I have created both a new Choice and String field to capture the output. (I was not sure which was the best type of field).

I have written the following "OnChange" script to populate either one of these fields with a value based on the Category selected. I have removed a number of Categories, and wondered if there is a more efficient syntax.

function onChange(control, oldValue, newValue, isLoading) {

if (isLoading || newValue == '') {

return;

}

// If the user changes the value of the "Category" field,

// set the default value for the "Type of Service" field

if (g_form.getValue('category')) {

if (newValue == '#####_ba' || newValue == '#####_cd' || newValue == '#####_edr' || newValue == '#####_mdr' || newValue == '#####_sdr' || newValue == '#####_ti' || newValue == '#####_tprm' || newValue == '#####_vi') {

g_form.setValue('u_type_of_service','1','SOC');

} else if (newValue == 'network'|| newValue == 'firewall' || newValue == 'wifi'|| newValue == 'lam') {

g_form.setValue('u_type_of_service','2','NOC');

} else if (newValue == 'database' || newValue == 'hardware'|| newValue == 'software' || newValue == 'other') {

g_form.setValue('u_type_of_service','3','Internal');

} else if (newValue == 'Sentinel' || newValue == 'Sentinel') {

g_form.setValue('u_type_of_service','4','Platform');

}

g_form.setReadOnly('u_type_of_service',true);

}

}

[Brad Bowman · Accepted solution]

Your script looks fine, and is what needs to be done in scenarios like this.  An alternate approach to consider is using the Switch statement

https://www.w3schools.com/js/js_switch.asp 

One is not necessarily better or more efficient than the other, but you may prefer coding the case/switch format, or reading it when you or someone else comes back to update this script later.

Assuming you are running this onChange of Category, you don't need 

if (g_form.getValue('category')) {

since the very first if statement stops the script from running if the field was changed to blank/empty.

[Akshay Gupta2 · Accepted solution]

Hi @Damian Mudge ,

You are correct with onchange client script.

I have just modified the code for you. This should just work fine for your use case.

You can replace client script with this snippet.

function onChange(control, oldValue, newValue, isLoading) {
    if (isLoading || newValue == '') {
        return;
    }

    var categoryMapping = {
        '#####_ba': 'SOC',
        '#####_cd': 'SOC',
        '#####_edr': 'SOC',
        '#####_mdr': 'SOC',
        '#####_sdr': 'SOC',
        '#####_ti': 'SOC',
        '#####_tprm': 'SOC',
        '#####_vi': 'SOC',
        'network': 'NOC',
        'firewall': 'NOC',
        'wifi': 'NOC',
        'lam': 'NOC',
        'database': 'Internal',
        'hardware': 'Internal',
        'software': 'Internal',
        'other': 'Internal',
        'Sentinel': 'Platform'
    };

    var typeMapping = {
        'SOC': '1',
        'NOC': '2',
        'Internal': '3',
        'Platform': '4'
    };

    var typeOfService = categoryMapping[newValue];
    if (typeOfService) {
        g_form.setValue('u_type_of_service', typeMapping[typeOfService], typeOfService);
        g_form.setReadOnly('u_type_of_service', true);
    }
}

Please mark this as solution and helpful.

Thanks 

Akshay

[Damian Mudge]

HI Akshay, 

I have another scenario, that I missed,  When users input data everything maps as should coutesy of your onChange script. However, we direct input from other sources such as MS Sentinel which uses playbooks to populate the "Category". The onChange does not cover this scenario, so I think that an "onLoad" ClientScript would be ideal. I was trying to reverse engineer your script it based on other onLoad scripts, but with no success. What would be the syntax if this was an onLoad script? 

The user story would be:

On loading if the "category" is null, then do nothing. If the "category" is populated then update the type of service based on the mapping. 

Kind regards, 

Damian

[Damian Mudge]

I could not reverse engineer your advanced script as an onLoad but reworked my original one and it works as expected:

function onLoad() {

//Type appropriate comment here, and begin script below

if (g_form.getValue('category')) {

var newValue = (g_form.getValue('category'));

if (newValue == 'itc_ba' || newValue == 'itc_cd'|| newValue == 'itc_edr'|| newValue == 'itc_mdr'|| newValue == 'itc_mxdr'|| newValue == 'itc_mxdr_ba'|| newValue == 'itc_mxdr_ba'|| newValue == 'itc_mxdr_cloudapps'|| newValue == 'itc_mxdr_eiot'|| newValue == 'itc_mxdr_endpoint'|| newValue == 'itc_mxdr_identity'|| newValue == 'itc_mxdr_ir_rapid'|| newValue == 'itc_mxdr_ir_super'|| newValue == 'itc_mxdr_office365'|| newValue == 'itc_mxdr_ot'|| newValue == 'itc_mxdr_sql'|| newValue == 'itc_mxdr_storage'|| newValue == 'itc_mxdr_vm'|| newValue == 'itc_siem'|| newValue == 'itc_ti'|| newValue == 'itc_tprm'|| newValue == 'itc_vi') {

g_form.setValue('u_type_of_service','4','SOC');

} else if (newValue == 'itc_fw'|| newValue == 'itc_lan'|| newValue == 'itc_log_mgmt'|| newValue == 'itc_monms'|| newValue == 'itc_nac'|| newValue == 'itc_san'|| newValue == 'itc_wan'|| newValue == 'itc_wan_optimisation'|| newValue == 'itc_wifi') {

g_form.setValue('u_type_of_service','2','NOC');

} else if (newValue == 'database') {

g_form.setValue('u_type_of_service','1','Internal');

}

g_form.setReadOnly('u_type_of_service',true);

}

}

[Damian Mudge]

Thank you much for this. It worked perfectly once I replaced the ###### with my specific values. I do have a follow on question.

The field 'u_type_of_service' field has to be visible on the incident form in order for this to work. When I add it to the form it works perfectly, but when I remove it, it does not update. Is there something else I should be doing so that the 'u_type_of_service' field is updated behind the scenes so to speak. 

[Sheldon Swift · Accepted solution]

Hi @Damian Mudge - You would typically make the field visible, set its value, then hide it. It is possible to use GlideAjax, however, in most cases that would not be the most appropriate or efficient method.

While GlideAjax can be used to update the value of a hidden field, it involves an additional server call, which can be less efficient and more complex compared to handling the field visibility and value setting directly on the client side. GlideAjax is more appropriate for scenarios where server-side processing is required beyond simple field value setting.

[Damian Mudge]

Thank you.