Flow designer error : JSON string "remake"

Averyy
Tera Contributor

‎01-22-2024 07:03 AM - edited ‎01-22-2024 07:07 AM

Hello, apologies as I created this question before with alot of missing information. 

I am creating an activity set for our HR process that mirrors an already working activity set/tasks(other activity set creator is not available). Both activity sets are to take the new hire document they upload is passed down to 3 other tasks and filled out and once filled out, it is approved/rejected by the "PSS group" as below:

Averyy_0-1705933823838.png

Averyy_0-1705936005954.png

 

^^^ the end goal for "SIPR form approve/reject"

 

Everything is the same following exactly how the other activity set is, but I get a JSON error in my flow designer. Doing more research I found a record producer I could possibly be something causing the error. I will post the script as well as my own. I switched out the sysid as those will not be the same in the business rule. but everything else used is and to my knowledge should be as even the form being used on my activity set is the same form on other activity set. (I have put in BOLD what I think maybe causing the JSON error in the business rule and trying to organize this info as much as possible as I know this is alot of work, please bare with me and thank you to whomever takes to time to help me!)

 

I have take snapshots in this order:

1. my activity set/tasks

2. example(other activity set) of what "SIPR Form approve/reject"

3.JSON error in flow designer

4. Flow designer variable "Approval" that uses JSON

5. Other activity set business rule "when to run" 

6. My activity set business rule " when to run"

7. My flow designer

 

 

My flow design JSON error:

Averyy_2-1705934406730.png

Averyy_4-1705934569408.png

^^^ something in flow designer variable causing error

Averyy_3-1705934533058.png

Other activity set Business Rule: snapshot & "Advance tab" script

 

(function executeRule(current, previous /*null when async*/ ) {

    // Add your code here
    var title = 'New Hire DD2875 form';
    var copyAttachment = true;
    var taskTemplate = '';

    if (current.template == 'f17b26d01b3e4910d6892175604bcb80') { //Supervisor completes New Hire's DD2875 form
        taskTemplate = 'a7eef49c1b764910d6892175604bcb06';
        copyAttachment = false; //attachement is now being copied through flow called "Handle Activities for DD2875"
    } else if (current.template == 'd727f3ca1b556d10178ac88c0a4bcbbb') { //DD2875 Form Approve/Reject
        taskTemplate = 'a7eef49c1b764910d6892175604bcb06';
    } else if (current.template == '87fdba141b7e4910d6892175604bcba4') { //Security completes DD2875 form
        taskTemplate = 'f17b26d01b3e4910d6892175604bcb80';
        copyAttachment = false; //attachement is now being copied through flow called "Handle Activities for DD2875"
    } else if (current.template == '2b168f1c1b7e4910d6892175604bcb4a') { //Information Assurance completes DD2875 form
        taskTemplate = '87fdba141b7e4910d6892175604bcba4';
        copyAttachment = false; //attachement is now being copied through flow called "Handle Activities for DD2875"
    } else if (current.template == 'f2074f5c1b7e4910d6892175604bcbfc') { //PSS Reviews Completed DD2875 form
        taskTemplate = '2b168f1c1b7e4910d6892175604bcb4a';
        copyAttachment = false; //attachement is now being copied through flow called "Handle Activities for DD2875"
    } else if (current.template == '6f0309811bc7cd10178ac88c0a4bcb53') { //Sign Telework Agreement #2946
        //Commenting the below lines and also adding copyAttachment as false
        //as this action is now performed through the flow called
        //Telework read attachment from parent case
        //if needed we can completely remove this else if condition for
        //6f0309811bc7cd10178ac88c0a4bcb53 from this BR
        //title = 'Telework Agreement Document';
        //taskTemplate = '419e21ed1bebc950d6892175604bcbfc';
        copyAttachment = false;
    } else if (current.template == 'a7eef49c1b764910d6892175604bcb06') { //New Hire Completes DD2875 form
        var reason = "";
        var att = "";
        if (current.parent.payload != "") {
            gs.info("[KM] - PAYL: " + current.parent.payload);          
            var payload = JSON.parse(current.parent.payload);
            if (payload.hasOwnProperty("rejection_reason")) {
                reason = payload.rejection_reason.toString();
                att = payload.attachment_link.toString();
            }
        }
        copyAttachment = false;
        if (reason != "") {
            var fullDesc = "<strong>DD2875 form you submitted was rejected by the PSS</strong><p>Please see the rejection reason below. To make the necessary corrections either download the DD2875 form attached from PSS or the new DD2875 form from the links provided below.</p>";
            fullDesc += current.rich_description;
            fullDesc += '<strong>Rejection Reason:</strong><p>' + reason + '</p>';
            fullDesc += '<a title="Download DD2875 Attached from PSS" href="sys_attachment.do?sys_id=' + att + '" rel="nofollow" target="_blank" download>Download DD2875 Attached from PSS</a>';
            fullDesc += '<br /><br /><p>If you are having issues updating the DD2875 form attached from PSS, please download and use the new DD2875 form from the link below.</p>';
            fullDesc += '<a title="Download DD2875 Form here" href="sys_attachment.do?sys_id=' + gs.getProperty('sn_hr_le.DD2875 form') + '" rel="nofollow" target="_blank" download>Download DD2875 Form here</a>';
            current.rich_description = fullDesc;
        } else {
            current.rich_description = current.rich_description + '<a title="Download DD2875 Form here" href="sys_attachment.do?sys_id=' + gs.getProperty('sn_hr_le.DD2875 form') + '" rel="nofollow" target="_blank" download>Download DD2875 Form here</a>';
        }
    } else if (current.template == '419e21ed1bebc950d6892175604bcbfc') {
        copyAttachment = false;
        current.rich_description = current.rich_description + '<p>' + current.description + '</p><p><a title="Telework Agreement Document" href="sys_attachment.do?sys_id=' + gs.getProperty('sn_hr_le.Telework Agreement') + '" rel="nofollow" target="_blank" download>Telework Agreement #2946</a></p>';
    }

    if (copyAttachment) {
        var grNewHireTask = new GlideRecord('sn_hr_core_task');
        grNewHireTask.addQuery('parent', current.parent);
        grNewHireTask.addQuery('template', taskTemplate);
        grNewHireTask.query();

        if (grNewHireTask.next()) {
            var attachment = new GlideRecord('sys_attachment');
            attachment.addQuery('table_sys_id', grNewHireTask.sys_id);
            attachment.query();
            if (attachment.next())
                current.rich_description = current.rich_description + ' <p><a title="' + title + '" href="/sys_attachment.do?sys_id=' + attachment.sys_id + '" target="_blank" download>' + title + '</a></p>';
        }
    }

})(current, previous);

 

My activity set Business Rule: snapshot & "Advance tab" script

Averyy_6-1705935010217.png

(function executeRule(current, previous /*null when async*/ ) {

    // Add your code here
    var title = 'New Hire SIPR form';
    var copyAttachment = true;
    var taskTemplate = '';

    if (current.template == 'a299d0381b233514c88021f5624bcb99') { //Supervisor completes New Hire's SIPR form
        taskTemplate = '9f8786721b97f5d0c88021f5624bcb76';
        copyAttachment = false; //attachement is now being copied through flow called "Handle Activities for SIPR"
    } else if (current.template == 'fbc5f4781be33514c88021f5624bcba6') { //SIPR Form Approve/Reject
        taskTemplate = '9f8786721b97f5d0c88021f5624bcb76';
    } else if (current.template == '43a590f01b233514c88021f5624bcbcd') { //Security completes SIPR form
        taskTemplate = 'a299d0381b233514c88021f5624bcb99';
        copyAttachment = false; //attachement is now being copied through flow called "Handle Activities for SIPR"
    } else if (current.template == '41fa10f81b233514c88021f5624bcb99') { //Information Assurance completes SIPR form
        taskTemplate = '43a590f01b233514c88021f5624bcbcd';
        copyAttachment = false; //attachement is now being copied through flow called "Handle Activities for SIPR"
    } else if (current.template == '39d98c6f1b5bf9d0c88021f5624bcb89') { //PSS Reviews Completed SIPR form
        taskTemplate = '41fa10f81b233514c88021f5624bcb99';
        copyAttachment = false; //attachement is now being copied through flow called "Handle Activities for SIPR"
    } else if (current.template == '6f0309811bc7cd10178ac88c0a4bcb53') { //Sign Telework Agreement #2946
        //Commenting the below lines and also adding copyAttachment as false
        //as this action is now performed through the flow called
        //Telework read attachment from parent case
        //if needed we can completely remove this else if condition for
        //6f0309811bc7cd10178ac88c0a4bcb53 from this BR
        //title = 'Telework Agreement Document';
        //taskTemplate = '419e21ed1bebc950d6892175604bcbfc';
        copyAttachment = false;
    } else if (current.template == '9f8786721b97f5d0c88021f5624bcb76') { //New Hire Completes SIPR form
        var reason = "";
        var att = "";
        if (current.parent.payload != "") {
            gs.info("[KM] - PAYL: " + current.parent.payload);          
            var payload = JSON.parse(current.parent.payload);
            if (payload.hasOwnProperty("rejection_reason")) {
                reason = payload.rejection_reason.toString();
                att = payload.attachment_link.toString();
            }
        }
        copyAttachment = false;
        if (reason != "") {
            var fullDesc = "<strong>SIPR form you submitted was rejected by the PSS</strong><p>Please see the rejection reason below. To make the necessary corrections either download the SIPR form attached from PSS or the new SIPR form from the links provided below.</p>";
            fullDesc += current.rich_description;
            fullDesc += '<strong>Rejection Reason:</strong><p>' + reason + '</p>';
            fullDesc += '<a title="Download SIPR Attached from PSS" href="sys_attachment.do?sys_id=' + att + '" rel="nofollow" target="_blank" download>Download SIPR Attached from PSS</a>';
            fullDesc += '<br /><br /><p>If you are having issues updating the SIPR form attached from PSS, please download and use the new SIPR form from the link below.</p>';
            fullDesc += '<a title="Download SIPR Form here" href="sys_attachment.do?sys_id=' + gs.getProperty('sn_hr_le.SIPR form') + '" rel="nofollow" target="_blank" download>Download SIPR Form here</a>';
            current.rich_description = fullDesc;
        } else {
            current.rich_description = current.rich_description + '<a title="Download SIPR Form here" href="sys_attachment.do?sys_id=' + gs.getProperty('sn_hr_le.SIPR form') + '" rel="nofollow" target="_blank" download>Download SIPR Form here</a>';
        }
    } //else if (current.template == '419e21ed1bebc950d6892175604bcbfc') {
        //copyAttachment = false;
        //current.rich_description = current.rich_description + '<p>' + current.description + '</p><p><a title="Telework Agreement Document" href="sys_attachment.do?sys_id=' + gs.getProperty('sn_hr_le.Telework Agreement') + '" rel="nofollow" target="_blank" download>Telework Agreement #2946</a></p>';
    //}

if (copyAttachment) {
        var grNewHireTask = new GlideRecord('sn_hr_core_task');
        grNewHireTask.addQuery('parent', current.parent);
        grNewHireTask.addQuery('template', taskTemplate);
        grNewHireTask.query();

        if (grNewHireTask.next()) {
            var attachment = new GlideRecord('sys_attachment');
            attachment.addQuery('table_sys_id', grNewHireTask.sys_id);
            attachment.query();
            if (attachment.next())
                current.rich_description = current.rich_description + ' <p><a title="' + title + '" href="/sys_attachment.do?sys_id=' + attachment.sys_id + '" target="_blank" download>' + title + '</a></p>';
        }
    }

})(current, previous);

 

My Flow Designer:

Averyy_8-1705935749974.png

 

 

0 Helpfuls
  • 457 Views
1 REPLY 1

Aniket Chavan
Tera Sage
Tera Sage

‎01-22-2024 09:17 AM

Hello @Averyy ,

You can give a try to the modified business rules scripts below and let me know how it works for you.

For "New Hire SIPR Form" Business Rule:

(function executeRule(current, previous /*null when async*/ ) {
    // Add your code here

    // ...

    var reason = "";
    var att = "";

    try {
        if (current.parent.payload) {
            var payload = JSON.parse(current.parent.payload);

            if (payload.rejection_reason) {
                reason = payload.rejection_reason.toString();
            }

            if (payload.attachment_link) {
                att = payload.attachment_link.toString();
            }
        }
    } catch (e) {
        gs.error("[New Hire SIPR Form Business Rule] Error parsing JSON: " + e);
    }

    // ... (rest of the script)

})(current, previous);

 

For "New Hire DD2875 Form" Business Rule:

(function executeRule(current, previous /*null when async*/ ) {
    // Add your code here

    // ...

    var reason = "";
    var att = "";

    try {
        if (current.parent.payload) {
            var payload = JSON.parse(current.parent.payload);

            if (payload.rejection_reason) {
                reason = payload.rejection_reason.toString();
            }

            if (payload.attachment_link) {
                att = payload.attachment_link.toString();
            }
        }
    } catch (e) {
        gs.error("[New Hire DD2875 Form Business Rule] Error parsing JSON: " + e);
    }

    // ... (rest of the script)

})(current, previous);

 

Let me know your views on this and Mark ✅Correct if this solves your query and also mark 👍Helpful if you find my response worthy based on the impact.

 

Thanks,

Aniket

0 Helpfuls