Your question got me to rethink my answer.
I tought instead of doing all these scripts override which are global and override OOTB stuff, you can simply create a scripted user criteria and apply it as the only user criteria for the required knowledge bases. However, these user criteria are somehow cached in the user session, so for example: a user is the author of an article, he changes the author to someone else so that he should no longer have write access, however he keeps the write access because of a weird caching with user criteria. I conclude that user criteria should not be used to be dynamic with the record.
However, your point about the canContribute method is good, you could in fact make this simpler by overriding the canContribute method that is defined in KBCommon. And remove the previous overriding I proposed:
var KBCommon = Class.create();
KBCommon.prototype = Object.extendsObject(KBCommonSNC, {
initialize: function(){
this._knowledgeHelper = new SNC.KnowledgeHelper();
this._knowledgeHelper.canContribute = function(knowledgeGR){
var defaultContribute = new SNC.KnowledgeHelper().canContribute(knowledgeGR);
if(!defaultContribute){
return false;
}
var isAdmin = gs.hasRole('admin');
if(isAdmin){
return true;
}
var isKnowledgeBase = knowledgeGR.getRecordClassName() == 'kb_knowledge_base';
if(isKnowledgeBase){
return true;
}
var isAuthor = knowledgeGR.author == gs.getUserID();
if(isAuthor){
return true;
}
var isMemberOfCIGroup = gs.getUser().isMemberOf(knowledgeGR.cmdb_ci.support_group);
if(isMemberOfCIGroup){
return true;
}
return false;
};
},
type: 'KBCommon'
});
